[18.0][MIG] fts_base#6
Merged
Merged
Conversation
[IMP] open results in a form
…and one to open in edit mode
[ADD] read fulltextsearch config from database wide parameter (ir.config_parameter)
[IMP] add 7.0 compatibility code
[IMP] description [IMP] use _register_hook to instantiate search plugins, this gets rid of a lot of problems
[FIX] config pages shows all available search plugins instead of installed ones
This is also needed for attachment indexing hitting postgres limits.
ntsirintanis
force-pushed
the
18.0-mig-fts_base
branch
from
907efd9 to
83cf0d4
Compare
Contributor
|
@ntsirintanis Do we already have an instance where we can run actual tests? |
NL66278
reviewed
Jun 25, 2026
| return { | ||
| "type": "ir.actions.act_window", | ||
| "res_model": self.res_model, | ||
| "view_type": "form", |
Contributor
There was a problem hiding this comment.
Remove this line (should already have been done in 16.0). There is no more view_type field / key for a window action (or any other action). The log shows this (might be of another action but anyway):
2026-06-25 09:44:06,256 1033174 WARNING odovrsdem18 odoo.addons.web.controllers.utils: Action {'type': 'ir.actions.act_window', 'res_model': 'ir.attachment', 'view_type': 'form', 'view_mode': 'form,list', 'res_id': 216, 'views': [(239, 'form')]} contains custom properties 'view_type'. Passing them via the `params` or `context` properties is recommended instead
NL66278
reviewed
Jun 25, 2026
| <data> | ||
| <record id="action_fts_config" model="ir.actions.act_window"> | ||
| <field name="name">Fulltextsearch configuration</field> | ||
| <field name="view_type">form</field> |
Contributor
There was a problem hiding this comment.
Remove view_type here also.
Contributor
|
@ntsirintanis Two small changes and we are good to go. Tested this and works well. |
Contributor
|
@ntsirintanis Might be usefull to compare this: OCA/server-tools#3652 |
Contributor
|
@ntsirintanis as you where on holiday did the changes myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.