fix: include simulation save flags#137
Open
samsamtrum wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
saveandsave_if_failsto simulation transaction parameters and forwards both fields into the API request body for single and bundle simulations.The SDK currently lets callers build simulation requests from
TransactionParameters, but those two API-supported flags are missing from the type and are dropped whencall_argsis built.Also adds a focused request-builder test covering both single and bundle simulations.
Checked with:
git diff --checkcorepack pnpm install --ignore-scripts --frozen-lockfilecorepack pnpm exec jest test/simulator.request.test.ts --runInBandcorepack pnpm exec tsc --noEmitRefs #98