Skip to content

feat: improve share message, fix double dialog on mobile #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
T1LT merged 1 commit into from
Aug 17, 2025
Merged

feat: improve share message, fix double dialog on mobile #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/(recipes)/recipe/[id]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export default async function RecipeItem({
</p>
</div>
<div className="h-full flex items-center gap-2">
<ShareButton />
<ShareButton recipe={recipe} />
<LikeButton
likes={recipe.likes}
recipeId={recipe.id}
Expand Down
35 changes: 27 additions & 8 deletions app/(recipes)/recipe/[id]/share-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,23 @@ import { useState, useEffect } from "react";
import Image from "next/image";
import Link from "next/link";

export default function ShareButton() {
type RecipeType = {
title: string;
id: string;
likes: number;
image_url: string | null;
cuisine: string;
category: string;
prepTime: number;
ingredients: string;
procedure: string;
username: string | null;
submitted_by: string | null;
created_at: Date;
updated_at: Date;
};

export default function ShareButton({ recipe }: { recipe: RecipeType }) {
const pathname = usePathname();
const { toast } = useToast();
const [isMobile, setIsMobile] = useState(false);
Expand All @@ -36,7 +52,9 @@ export default function ShareButton() {
setIsMobile(isMobileDevice && hasNativeSharing);
}, []);

const shareUrl = `https://dishcraft.vercel.app${pathname}`;
const shareUrl = `https://dishcraft.vercel.app/${recipe.id.replace("_", "/")}`;
const shareTitle = `Check out ${recipe.title} by ${recipe.username} on DishCraft`;
const encodedShareTitle = encodeURIComponent(`${shareTitle}: ${shareUrl}`);

async function copyLink() {
try {
Expand All @@ -52,12 +70,13 @@ export default function ShareButton() {
if (isMobile) {
try {
await navigator.share({
title: "Check out this recipe!",
title: shareTitle,
url: shareUrl,
});
} catch (error) {
// Fallback to dialog if sharing is cancelled or fails
setIsOpen(true);
// On mobile, don't show dialog - just silently fail
// This ensures only native sharing is used on mobile
console.log("Native sharing failed or was cancelled");
}
} else {
setIsOpen(true);
Expand Down Expand Up @@ -94,7 +113,7 @@ export default function ShareButton() {
asChild
>
<Link
href={`https://wa.me/?text=${encodeURIComponent(`Check out this recipe: ${shareUrl}`)}`}
href={`https://wa.me/?text=${encodedShareTitle}`}
target="_blank"
>
<Image
Expand All @@ -114,7 +133,7 @@ export default function ShareButton() {
asChild
>
<Link
href={`https://twitter.com/intent/tweet?text=${encodeURIComponent(`Check out this recipe: ${shareUrl}`)}`}
href={`https://twitter.com/intent/tweet?text=${encodedShareTitle}`}
target="_blank"
>
<Image
Expand All @@ -134,7 +153,7 @@ export default function ShareButton() {
asChild
>
<Link
href={`https://www.facebook.com/sharer/sharer.php?u=${encodeURIComponent(shareUrl)}`}
href={`https://www.facebook.com/sharer/sharer.php?u=${shareUrl}`}
target="_blank"
>
<Image
Expand Down