Skip to content

[Refactor:System] Remove submitty_count from default#75

Draft
dagemcn wants to merge 1 commit into
mainfrom
deprecate-submitty-count-DI
Draft

[Refactor:System] Remove submitty_count from default#75
dagemcn wants to merge 1 commit into
mainfrom
deprecate-submitty-count-DI

Conversation

@dagemcn

@dagemcn dagemcn commented Jun 25, 2026

Copy link
Copy Markdown
Member

What is the current behavior?

Fixes Submitty Issue#11784 - This one of the companion PRs to Submitty PR#12609.

What is the new behavior?

submitty_count is longer installed in preparation for deprecation.

Other information?

This is a breaking change. Any autograding that uses the old submitty_count instead of submitty_count_ts will no longer work.

  1. Follow the instructions on this page up to step 6 with the Dockerfile modified in this PR. (you may be able to reuse the one I used dagemcn/dockerimages:default-test adding it through docker UI)
  2. After you have added the new docker image with the DockerUI, update the config of any gradeable with submitty_count with
"autograding_method": "docker",
"container_options": {
    "container_image": "IMAGE_NAME"
},

where IMAGE_NAME is the name of the image, for example, dagemcn/dockerimages:default-test if you reused mine.
3. Create a gradeable using submitty_count, (Tutorial examples 04, 06, and 07 all utilize submitty_count)
4. Test that submitty_count will not work in the config and that submitty_count_ts successfully runs
5. Also test that regular autograding works successfully on the image

Attached is a zip of a sample solution and gradeable config with both submitty_count and submitty_count_ts commands present for testing.
example.zip

@dagemcn dagemcn changed the title Remove install of submitty_count from autograding-default [Refactor:System] Remove install of submitty_count from autograding-default Jun 25, 2026
@dagemcn dagemcn changed the title [Refactor:System] Remove install of submitty_count from autograding-default [Refactor:System] Remove submitty_count from autograding-default Jun 25, 2026
@dagemcn dagemcn changed the title [Refactor:System] Remove submitty_count from autograding-default [Refactor:System] Remove submitty_count from docker Jun 25, 2026
@dagemcn dagemcn changed the title [Refactor:System] Remove submitty_count from docker [Refactor:System] Remove submitty_count from default Jun 25, 2026
@roye2 roye2 self-requested a review July 7, 2026 14:08

@roye2 roye2 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to test that submitty_count no longer works for autograding, and that submitty_count_ts works for autograding with the changes to the docker image. This PR looks good to me.

@bmcutler bmcutler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than just edit the dockerfile, we should make a new version/tag (ubuntu22.04_v2 or something -- this will be a new directory), and have latest point to the new tag (in the metadata.json file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants