chore: migrate wrapper to call Master Workflow.yml directly - #5
Open
SkylineCICD wants to merge 1 commit into
Open
chore: migrate wrapper to call Master Workflow.yml directly#5SkylineCICD wants to merge 1 commit into
SkylineCICD wants to merge 1 commit into
Conversation
The 'internal-nuget' legacy master workflow is a thin wrapper around Master Workflow.yml. Removing it shortens the call chain by one job, exposes the full set of Master Workflow inputs (e.g. runs-on), and lets us evolve inputs without breaking callers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
SkylineCICD
added
the
wrapper-migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened automatically by the
Wrapper Migration Workflow in
SkylineCommunications/_ReusableWorkflows.What changed
The wrapper workflow file(s) in
.github/workflows/wereupdated to call
SkylineCommunications/_ReusableWorkflows/.github/workflows/Master Workflow.ymldirectly instead of the legacy
internal-nuget master wrapper. Input and
secret names were renamed to the kebab-case / SHOUTING_CASE
names that
Master Workflow.ymlexpects, and any obsoletepassthrough inputs (
referenceName,runNumber,referenceType,repository,owner, …) were dropped.Why
The legacy
NuGet Solution,Internal NuGet SolutionandDataMiner App Packagesmaster workflows are thin wrappersthat internally call
Master Workflow.yml. Removing theindirection:
Master Workflow.ymlinputs(e.g.
runs-on) without us having to forward each onethrough every wrapper;
callers.
Review checklist
with:values that werepreviously passed through (only the keys were
renamed).
secrets:mappings are intact.around the legacy
uses:call, verify they stillmake sense pointing at the master workflow.
Idempotent: re-running the legacy wrapper while this PR
is open will not create another one.