Fix the bug that occurs when setting the factor for a grade subject that doesn't yet exist.#2213
Open
nilsreichardt wants to merge 2 commits into
Open
Fix the bug that occurs when setting the factor for a grade subject that doesn't yet exist.#2213nilsreichardt wants to merge 2 commits into
nilsreichardt wants to merge 2 commits into
Conversation
…hat doesn't yet exist.
github-actions
Bot
added
testing
feature: grades
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively addresses a bug where setting a weight for a non-existent subject would fail. The logic is now correct, ensuring the subject reference is updated after creation. The addition of a corresponding test case is a great way to prevent regressions. I've included one minor suggestion to align the code with the Dart style guide.
|
Visit the preview URL for this PR (updated for commit 1148d70): https://sharezone-test--pr2213-fix-bug-of-setting-f-t6ww33nu.web.app (expires Sun, 05 Apr 2026 22:49:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2212