feat: replace playback speed buttons with floating speed selector (#1072)#1133
Closed
anjalikumari45 wants to merge 1 commit into
Closed
feat: replace playback speed buttons with floating speed selector (#1072)#1133anjalikumari45 wants to merge 1 commit into
anjalikumari45 wants to merge 1 commit into
Conversation
…2318#1072) - Created FloatingSpeedSelector component with speeds 0.5x to 2x - Highlights currently selected speed visually - Dismisses on speed selection or outside tap - Replaced handleCycleSpeed with handleSpeedSelect in PodcastPlayer.tsx - Replaced handleSpeedChange cycling logic in ArticleScreen.tsx - Updated PLAYBACK_SPEEDS array to include 0.5x, 0.75x, 1.75x - Applied floating selector on both Article and Podcast screens
Contributor
|
Thank you @, for creating the PR and contributing to our UltimateHealth project 💗. |
7 tasks
Owner
|
Sorry @anjalikumari45, I can't accept this PR. You are not assigned to the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Replaced the existing cycling playback speed buttons on Article and Podcast screens with a floating speed selector menu that displays all available speeds in a compact list, improving UX with fewer taps and better visual feedback.
Type of Change
Select your work-area
Related Issue
Fixes #1072
Changes Made
FloatingSpeedSelector.tsxcomponent supporting speeds: 0.5x, 0.75x, 1x, 1.25x, 1.5x, 1.75x, 2xhandleCycleSpeedwithhandleSpeedSelectinPodcastPlayer.tsxhandleSpeedChangelogic inArticleScreen.tsxPLAYBACK_SPEEDSarray to include all 7 speedsFixes
Closes #1072
Checklist
Undertaking