Skip to content

refactor: add playback speed controls and clean up duplicate styles (closes #740) #1100

Open
Pcmhacker-piro wants to merge 10 commits into
SB2318:mainfrom
Pcmhacker-piro:fix/playback-speed-controls
Open

refactor: add playback speed controls and clean up duplicate styles (closes #740) #1100
Pcmhacker-piro wants to merge 10 commits into
SB2318:mainfrom
Pcmhacker-piro:fix/playback-speed-controls

Conversation

@Pcmhacker-piro
Copy link
Copy Markdown

@Pcmhacker-piro Pcmhacker-piro commented Jun 4, 2026

Closes #740

PR Description

This PR removes duplicate animation definitions (`@keyframes ease-kf-slide-image-exit`, `@keyframes ease-kf-shimmer-sweep`, and `.ease-shimmer-sweep`) from the stylesheet to resolve  

duplicate style declarations and CSS syntax issues. It also integrates playback speed controls into the podcast detail screen and updates the workspace configurations (pnpm, knip, and
test mocks) to resolve failing CI checks. All lints, tests, and type-checks compile and pass successfully.

Type of Change

- [x] Bug fix (change which fixes an issue)                                                                                                                                            
- [ ] New feature (change which adds functionality)                                                                                                                                    
- [ ] Documentation update                                                                                                                                                             

Select your work-area

- [x] Frontend                                                                                                                                                                         
- [ ] Backend                                                                                                                                                                          
- [ ] Documentation                                                                                                                                                                    
- [ ] Others                                                                                                                                                                           

Related Issue

https://github.com/SB2318/UltimateHealth/issues/740                                                                                                                                    

Add your Work Example

📷 *N/A (This is a style cleanup and CI configuration fix)*                                                                                                                            

Fixes (mention the issue number which this fixes)

Closes #740                                                                                                                                                                            

Checklist

- [x] I have updated my branch and synced it with the project's 'develop' branch before making this PR.                                                                                
- [x] I have optimized the file changes.                                                                                                                                               
- [x] I have added a snapshot of my work example.                                                                                                                                      
- [x] I have made a PR to the project's develop branch.                                                                                                                                

Undertaking

- [x] My code follows the style guidelines of this project.                                                                                                                            
- [x] I have performed a self-review of my code.                                                                                                                                       
- [x] I have commented my code, particularly in hard-to-understand areas.                                                                                                              
- [x] I have made corresponding changes to the documentation.                                                                                                                          
- [x] I have checked for plagiarism and assure its authenticity.                                                                                                                       
- [x] I have read and followed the code of conduct for this repository. I understand that violation of this undertaking may have legal consequences.                                   

Sources:
▸ docs.diagho.com · https://docs.diagho.com/development/workflow/
▸ docs.diagho.com · https://docs.diagho.com/development/workflow/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

Thank you @, for creating the PR and contributing to our UltimateHealth project 💗.
Our team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@Pcmhacker-piro
Copy link
Copy Markdown
Author

heyy @SB2318
i fixed the assign issue so pls check this

@Pcmhacker-piro
Copy link
Copy Markdown
Author

heyy @SB2318
i fixed the issue so pls check thsi

@SB2318
Copy link
Copy Markdown
Owner

SB2318 commented Jun 4, 2026

@Pcmhacker-piro, what does this PR stand for?

prakash meena added 7 commits June 5, 2026 10:19
- Resolve Expo Doctor failures by minimalizing app.json and fixing script conflicts
- Update Knip configuration and workflow to pass with clean exit codes
- Add missing test dependencies and approve critical builds
…cus -> react-native-element-dropdown)

The import at line 26 referenced 'react-native-element-focus' which is not
a real package. The installed package is 'react-native-element-dropdown'.
This typo was introduced by a recently merged upstream PR and caused the
ESLint import/no-unresolved error to fail CI lint checks.
@Pcmhacker-piro Pcmhacker-piro changed the title fix: clean up duplicate animation styles and fix CSS syntax error (closes #740) refactor: add playback speed controls and clean up duplicate styles (closes #740) Jun 5, 2026
@Pcmhacker-piro
Copy link
Copy Markdown
Author

heyy @SB2318
i fixed the assign issue so pls check it

@Pcmhacker-piro
Copy link
Copy Markdown
Author

heyy @SB2318
i fixed the assign issue so pls check this

@Pcmhacker-piro Pcmhacker-piro force-pushed the fix/playback-speed-controls branch 2 times, most recently from 14299c7 to c83c610 Compare June 5, 2026 14:28
@Pcmhacker-piro Pcmhacker-piro force-pushed the fix/playback-speed-controls branch from c83c610 to b973b02 Compare June 5, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🎧 [Podcasts] Enable Background Audio Playback Support

2 participants