chore: OXC - #7515
Open
diegolmello wants to merge 3 commits into
Open
Conversation
Migrate linting from ESLint 8 to Oxlint. `pnpm lint` drops from ~1min to ~0.6s and 17 eslint packages are removed from devDependencies. Config lives in `.oxlintrc.json`, generated with `@oxlint/migrate` from the old `.eslintrc.js` and then tuned: - `eslint-plugin-react-native` is loaded through `jsPlugins`, since Oxlint has no built-in equivalent. - `import/extensions` is off. Its old options (`js: 'warning'`, ...) were not valid values for the rule, so it never reported anything under ESLint. - `no-unused-vars` sets `caughtErrors: 'none'` to match the ESLint 8 default. - `import/no-cycle` and the React Compiler rules report as warnings. They surface findings ESLint never showed, so they are not gated yet. Rules with no Oxlint equivalent are dropped: `no-restricted-syntax` (the ban on `React.*` member syntax), `import/order`, `import/no-unresolved` and `import/named`. ESLint 8 skipped dot-directories, so files under `.rnstorybook/` and `.maestro/` were never linted. Oxlint does lint them, which surfaced four violations that are fixed here. The CI workflow keeps its filename and job id so branch protection checks stay valid.
Migrate formatting from Prettier 2.8.8 to Oxfmt via `oxfmt --migrate prettier`. - `.oxfmtrc.json` carries every previous Prettier option unchanged (tabs, single quotes, printWidth 130, no trailing comma, avoid arrow parens, bracketSameLine) plus the `.prettierignore` patterns as `ignorePatterns`. `sortPackageJson` is disabled to match previous behavior. - `.prettierrc.js` and `.prettierignore` removed; `prettier` dropped from devDependencies. - `prettier-lint` script renamed to `format-lint` and now runs `oxfmt`. - 44 files reformatted: Oxfmt follows Prettier 3 style, so nested ternaries and `extends`/type-argument wrapping indent differently than under Prettier 2. No semantic changes. - prettier.yml still ran `eslint --fix`, missed in the Oxlint migration; it now runs `oxfmt` and `oxlint --fix`. `react/exhaustive-deps` is allowed there because its autofix rewrites dependency arrays, which changes behavior and must not land unreviewed from CI. - Workflow filename kept as prettier.yml to avoid disturbing branch protection checks, same as eslint.yml. Verified: `pnpm lint` exit 0 (0 errors), `tsc` clean, 217/217 suites and 2032/2032 tests pass, `oxfmt --check` clean.
diegolmello
had a problem deploying
to
approve_e2e_testing
July 24, 2026 20:06 — with 
GitHub Actions
Error
GitHub Actions
Error
Contributor
WalkthroughThe repository replaces ESLint and Prettier with Oxlint and Oxfmt, updates CI and documentation, and reformats source and test expressions. Two behavioral adjustments affect Maestro helper return handling and message-list index fallback evaluation. ChangesTooling migration
Code and test updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
diegolmello
temporarily deployed
to
approve_e2e_testing
July 24, 2026 20:09 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
diegolmello
temporarily deployed
to
android_build
July 24, 2026 20:13 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.oxlintrc.json:
- Line 3: Restore the complete intended plugin set in the root plugins
configuration at .oxlintrc.json:3, including the existing default plugins
alongside import, React, and Jest. Remove the TypeScript override plugins field
at .oxlintrc.json:90 so the override inherits the full root plugin set instead
of replacing it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 00d54fd1-d8d2-45d7-86ea-44addfc4b1f7
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (60)
.eslintignore.eslintrc.js.github/README.md.github/workflows/eslint.yml.github/workflows/prettier.yml.maestro/scripts/data-setup.js.oxfmtrc.json.oxlintrc.json.prettierignore.prettierrc.js.rnstorybook/generateSnapshots.tsx.rnstorybook/main.ts.rnstorybook/preview.tsxCLAUDE.mdCONTRIBUTING.mdapp/containers/ActionSheet/ActionSheet.tsxapp/containers/CustomIcon/index.tsxapp/containers/LoginServices/LoginServices.test.tsxapp/containers/MessageComposer/MessageComposer.test.tsxapp/containers/MessageComposer/MessageComposer.tsxapp/containers/MessageComposer/hooks/useAutocomplete.tsapp/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsxapp/containers/TextInput/FormTextInput.tsxapp/containers/UIKit/MessageBlock.tsxapp/containers/message/__tests__/index.test.tsxapp/containers/message/components/__tests__/Blocks.test.tsxapp/containers/message/components/__tests__/Content.test.tsxapp/containers/message/components/__tests__/Quote.test.tsxapp/containers/message/components/__tests__/RepliedThread.test.tsxapp/containers/message/components/__tests__/Reply.test.tsxapp/containers/message/components/__tests__/Thread.test.tsxapp/containers/message/hooks/__tests__/useMessageAccessibilityHint.test.tsxapp/containers/message/hooks/__tests__/useMessageAccessibilityLabel.test.tsxapp/containers/message/stores/__tests__/MessageStore.test.tsxapp/definitions/ILoggedUser.tsapp/definitions/ITeam.tsapp/definitions/rest/helpers/index.tsapp/definitions/utils.tsapp/lib/database/interfaces.tsapp/lib/methods/helpers/mergeSubscriptionsRooms.tsapp/lib/methods/loadMessagesForRoom.test.tsapp/lib/methods/roomTypeToApiType.tsapp/lib/methods/search.test.tsapp/lib/services/restApi.tsapp/lib/services/voip/MediaSessionInstance.test.tsapp/lib/services/voip/getPeerAutocompleteOptions.tsapp/reducers/login.tsapp/views/AddChannelTeamView.tsxapp/views/CannedResponsesListView/CannedResponseItem.tsxapp/views/ModalBlockView.tsxapp/views/RoomActionsView/components/CallSection.stories.tsxapp/views/RoomActionsView/components/CallSection.test.tsxapp/views/RoomInfoEditView/index.tsxapp/views/RoomInfoView/components/RoomInfoButtons.stories.tsxapp/views/RoomInfoView/components/RoomInfoButtons.test.tsxapp/views/RoomView/List/hooks/useMessages.test.tsxapp/views/RoomView/List/hooks/useScroll.tsapp/views/RoomView/List/index.tsxapp/views/RoomView/index.tsxpackage.json
💤 Files with no reviewable changes (5)
- .eslintignore
- .prettierignore
- .eslintrc.js
- .prettierrc.js
- .rnstorybook/preview.tsx
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
- GitHub Check: ESLint and Test / run-eslint-and-test
🧰 Additional context used
📓 Path-based instructions (6)
**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{js,ts,jsx,tsx}: Use descriptive names for functions, variables, and classes that clearly convey their purpose
Write comments that explain the 'why' behind code decisions, not the 'what'
Keep functions small and focused on a single responsibility
Use const by default, let when reassignment is needed, and avoid var
Prefer async/await over .then() chains for handling asynchronous operations
Use explicit error handling with try/catch blocks for async operations
Avoid deeply nested code; refactor complex logic into helper functions
Files:
app/containers/message/hooks/__tests__/useMessageAccessibilityHint.test.tsxapp/containers/message/components/__tests__/Thread.test.tsxapp/definitions/utils.tsapp/views/CannedResponsesListView/CannedResponseItem.tsxapp/containers/message/components/__tests__/RepliedThread.test.tsxapp/views/RoomInfoEditView/index.tsxapp/lib/methods/loadMessagesForRoom.test.tsapp/containers/UIKit/MessageBlock.tsxapp/lib/methods/search.test.tsapp/containers/message/components/__tests__/Reply.test.tsxapp/views/RoomInfoView/components/RoomInfoButtons.stories.tsxapp/containers/message/components/__tests__/Quote.test.tsxapp/containers/MessageComposer/hooks/useAutocomplete.tsapp/containers/CustomIcon/index.tsxapp/containers/MessageComposer/MessageComposer.test.tsxapp/lib/methods/roomTypeToApiType.tsapp/containers/message/stores/__tests__/MessageStore.test.tsxapp/containers/LoginServices/LoginServices.test.tsxapp/containers/message/components/__tests__/Content.test.tsxapp/containers/TextInput/FormTextInput.tsxapp/views/RoomInfoView/components/RoomInfoButtons.test.tsxapp/lib/services/voip/MediaSessionInstance.test.tsapp/views/RoomView/List/hooks/useMessages.test.tsxapp/views/AddChannelTeamView.tsxapp/containers/message/components/__tests__/Blocks.test.tsxapp/views/RoomView/List/index.tsxapp/definitions/ILoggedUser.tsapp/lib/methods/helpers/mergeSubscriptionsRooms.tsapp/definitions/ITeam.tsapp/views/RoomView/index.tsxapp/lib/services/voip/getPeerAutocompleteOptions.tsapp/containers/MessageComposer/MessageComposer.tsxapp/lib/database/interfaces.tsapp/containers/ActionSheet/ActionSheet.tsxapp/views/RoomActionsView/components/CallSection.stories.tsxapp/reducers/login.tsapp/containers/message/hooks/__tests__/useMessageAccessibilityLabel.test.tsxapp/views/ModalBlockView.tsxapp/views/RoomActionsView/components/CallSection.test.tsxapp/containers/message/__tests__/index.test.tsxapp/definitions/rest/helpers/index.tsapp/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsxapp/views/RoomView/List/hooks/useScroll.tsapp/lib/services/restApi.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx}: Use TypeScript for type safety; add explicit type annotations to function parameters and return types
Prefer interfaces over type aliases for defining object shapes in TypeScript
Use enums for sets of related constants rather than magic strings or numbers
**/*.{ts,tsx}: Use TypeScript strict mode for the React Native application.
Resolve application imports relative toapp/, using the configuredbaseUrlwhere appropriate.
Use Redux and Redux-Saga for application state management; keep actions as plain action creators, reducers responsible for state shape, and sagas responsible for side effects.
Run the formatter/linter and tests for modified files before committing; pre-commit hooks enforce these checks.
Files:
app/containers/message/hooks/__tests__/useMessageAccessibilityHint.test.tsxapp/containers/message/components/__tests__/Thread.test.tsxapp/definitions/utils.tsapp/views/CannedResponsesListView/CannedResponseItem.tsxapp/containers/message/components/__tests__/RepliedThread.test.tsxapp/views/RoomInfoEditView/index.tsxapp/lib/methods/loadMessagesForRoom.test.tsapp/containers/UIKit/MessageBlock.tsxapp/lib/methods/search.test.tsapp/containers/message/components/__tests__/Reply.test.tsxapp/views/RoomInfoView/components/RoomInfoButtons.stories.tsxapp/containers/message/components/__tests__/Quote.test.tsxapp/containers/MessageComposer/hooks/useAutocomplete.tsapp/containers/CustomIcon/index.tsxapp/containers/MessageComposer/MessageComposer.test.tsxapp/lib/methods/roomTypeToApiType.tsapp/containers/message/stores/__tests__/MessageStore.test.tsxapp/containers/LoginServices/LoginServices.test.tsxapp/containers/message/components/__tests__/Content.test.tsxapp/containers/TextInput/FormTextInput.tsxapp/views/RoomInfoView/components/RoomInfoButtons.test.tsxapp/lib/services/voip/MediaSessionInstance.test.tsapp/views/RoomView/List/hooks/useMessages.test.tsxapp/views/AddChannelTeamView.tsxapp/containers/message/components/__tests__/Blocks.test.tsxapp/views/RoomView/List/index.tsxapp/definitions/ILoggedUser.tsapp/lib/methods/helpers/mergeSubscriptionsRooms.tsapp/definitions/ITeam.tsapp/views/RoomView/index.tsxapp/lib/services/voip/getPeerAutocompleteOptions.tsapp/containers/MessageComposer/MessageComposer.tsxapp/lib/database/interfaces.tsapp/containers/ActionSheet/ActionSheet.tsxapp/views/RoomActionsView/components/CallSection.stories.tsxapp/reducers/login.tsapp/containers/message/hooks/__tests__/useMessageAccessibilityLabel.test.tsxapp/views/ModalBlockView.tsxapp/views/RoomActionsView/components/CallSection.test.tsxapp/containers/message/__tests__/index.test.tsxapp/definitions/rest/helpers/index.tsapp/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsxapp/views/RoomView/List/hooks/useScroll.tsapp/lib/services/restApi.ts
**/*.{ts,tsx,js,jsx,json}
📄 CodeRabbit inference engine (CLAUDE.md)
Follow Oxfmt formatting: tabs, single quotes, 130-character width, no trailing commas, omitted arrow-function parentheses where allowed, and same-line brackets.
Files:
app/containers/message/hooks/__tests__/useMessageAccessibilityHint.test.tsxapp/containers/message/components/__tests__/Thread.test.tsxapp/definitions/utils.tsapp/views/CannedResponsesListView/CannedResponseItem.tsxapp/containers/message/components/__tests__/RepliedThread.test.tsxapp/views/RoomInfoEditView/index.tsxapp/lib/methods/loadMessagesForRoom.test.tsapp/containers/UIKit/MessageBlock.tsxapp/lib/methods/search.test.tsapp/containers/message/components/__tests__/Reply.test.tsxapp/views/RoomInfoView/components/RoomInfoButtons.stories.tsxapp/containers/message/components/__tests__/Quote.test.tsxapp/containers/MessageComposer/hooks/useAutocomplete.tsapp/containers/CustomIcon/index.tsxapp/containers/MessageComposer/MessageComposer.test.tsxapp/lib/methods/roomTypeToApiType.tsapp/containers/message/stores/__tests__/MessageStore.test.tsxapp/containers/LoginServices/LoginServices.test.tsxapp/containers/message/components/__tests__/Content.test.tsxapp/containers/TextInput/FormTextInput.tsxapp/views/RoomInfoView/components/RoomInfoButtons.test.tsxapp/lib/services/voip/MediaSessionInstance.test.tsapp/views/RoomView/List/hooks/useMessages.test.tsxapp/views/AddChannelTeamView.tsxapp/containers/message/components/__tests__/Blocks.test.tsxapp/views/RoomView/List/index.tsxapp/definitions/ILoggedUser.tsapp/lib/methods/helpers/mergeSubscriptionsRooms.tsapp/definitions/ITeam.tsapp/views/RoomView/index.tsxapp/lib/services/voip/getPeerAutocompleteOptions.tsapp/containers/MessageComposer/MessageComposer.tsxapp/lib/database/interfaces.tsapp/containers/ActionSheet/ActionSheet.tsxapp/views/RoomActionsView/components/CallSection.stories.tsxapp/reducers/login.tsapp/containers/message/hooks/__tests__/useMessageAccessibilityLabel.test.tsxapp/views/ModalBlockView.tsxapp/views/RoomActionsView/components/CallSection.test.tsxapp/containers/message/__tests__/index.test.tsxapp/definitions/rest/helpers/index.tsapp/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsxapp/views/RoomView/List/hooks/useScroll.tspackage.jsonapp/lib/services/restApi.ts
app/lib/services/voip/**/*.ts
📄 CodeRabbit inference engine (CLAUDE.md)
Implement VoIP using Zustand stores and native CallKit/Telecom integration; do not conflate VoIP with the Redux/Saga-based VideoConf feature.
Files:
app/lib/services/voip/MediaSessionInstance.test.tsapp/lib/services/voip/getPeerAutocompleteOptions.ts
app/lib/database/**/*.ts
📄 CodeRabbit inference engine (CLAUDE.md)
Use WatermelonDB for local database models and schema, maintaining the local-first approach where the UI reads from the database and sagas synchronize with the server.
Files:
app/lib/database/interfaces.ts
app/lib/services/restApi.ts
📄 CodeRabbit inference engine (CLAUDE.md)
Use
fetchfor HTTP REST API requests through the REST API service.
Files:
app/lib/services/restApi.ts
🧠 Learnings (8)
📚 Learning: 2026-04-30T17:07:51.020Z
Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7274
File: app/lib/services/voip/MediaCallEvents.ts:0-0
Timestamp: 2026-04-30T17:07:51.020Z
Learning: In this Rocket.Chat React Native codebase, the ESLint rule `no-void: error` is enforced. When you see a promise returned from an async call that is not awaited (a “floating promise”), do not silence it with the `void somePromise()` pattern. Instead, handle the promise explicitly by attaching `.catch(...)` (or otherwise awaiting/handling the error) so unhandled-rejection risks are addressed in a way that satisfies the existing ESLint configuration.
Applied to files:
app/containers/message/hooks/__tests__/useMessageAccessibilityHint.test.tsxapp/containers/message/components/__tests__/Thread.test.tsxapp/definitions/utils.tsapp/views/CannedResponsesListView/CannedResponseItem.tsxapp/containers/message/components/__tests__/RepliedThread.test.tsxapp/views/RoomInfoEditView/index.tsxapp/lib/methods/loadMessagesForRoom.test.tsapp/containers/UIKit/MessageBlock.tsxapp/lib/methods/search.test.tsapp/containers/message/components/__tests__/Reply.test.tsxapp/views/RoomInfoView/components/RoomInfoButtons.stories.tsxapp/containers/message/components/__tests__/Quote.test.tsxapp/containers/MessageComposer/hooks/useAutocomplete.tsapp/containers/CustomIcon/index.tsxapp/containers/MessageComposer/MessageComposer.test.tsxapp/lib/methods/roomTypeToApiType.tsapp/containers/message/stores/__tests__/MessageStore.test.tsxapp/containers/LoginServices/LoginServices.test.tsxapp/containers/message/components/__tests__/Content.test.tsxapp/containers/TextInput/FormTextInput.tsxapp/views/RoomInfoView/components/RoomInfoButtons.test.tsxapp/lib/services/voip/MediaSessionInstance.test.tsapp/views/RoomView/List/hooks/useMessages.test.tsxapp/views/AddChannelTeamView.tsxapp/containers/message/components/__tests__/Blocks.test.tsxapp/views/RoomView/List/index.tsxapp/definitions/ILoggedUser.tsapp/lib/methods/helpers/mergeSubscriptionsRooms.tsapp/definitions/ITeam.tsapp/views/RoomView/index.tsxapp/lib/services/voip/getPeerAutocompleteOptions.tsapp/containers/MessageComposer/MessageComposer.tsxapp/lib/database/interfaces.tsapp/containers/ActionSheet/ActionSheet.tsxapp/views/RoomActionsView/components/CallSection.stories.tsxapp/reducers/login.tsapp/containers/message/hooks/__tests__/useMessageAccessibilityLabel.test.tsxapp/views/ModalBlockView.tsxapp/views/RoomActionsView/components/CallSection.test.tsxapp/containers/message/__tests__/index.test.tsxapp/definitions/rest/helpers/index.tsapp/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsxapp/views/RoomView/List/hooks/useScroll.tsapp/lib/services/restApi.ts
📚 Learning: 2026-06-25T18:37:25.526Z
Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7434
File: app/views/ScreenLockConfigView.test.tsx:16-22
Timestamp: 2026-06-25T18:37:25.526Z
Learning: In Rocket.Chat ReactNative tests that mock selectors for `useAppSelector`, don’t require the mocked selector input to be typed as `IApplicationState` when the fixture only includes a partial Redux state slice (e.g., only `server` and `settings`). Requiring the full `IApplicationState` type in that scenario forces unsafe `as IApplicationState` casts and undermines type-safety. For these narrowly scoped selector-mock fixtures, use a less strict type (e.g., `any`) to keep the mock focused on the slice under test.
Applied to files:
app/containers/message/hooks/__tests__/useMessageAccessibilityHint.test.tsxapp/containers/message/components/__tests__/Thread.test.tsxapp/containers/message/components/__tests__/RepliedThread.test.tsxapp/lib/methods/loadMessagesForRoom.test.tsapp/lib/methods/search.test.tsapp/containers/message/components/__tests__/Reply.test.tsxapp/containers/message/components/__tests__/Quote.test.tsxapp/containers/MessageComposer/MessageComposer.test.tsxapp/containers/message/stores/__tests__/MessageStore.test.tsxapp/containers/LoginServices/LoginServices.test.tsxapp/containers/message/components/__tests__/Content.test.tsxapp/views/RoomInfoView/components/RoomInfoButtons.test.tsxapp/lib/services/voip/MediaSessionInstance.test.tsapp/views/RoomView/List/hooks/useMessages.test.tsxapp/containers/message/components/__tests__/Blocks.test.tsxapp/containers/message/hooks/__tests__/useMessageAccessibilityLabel.test.tsxapp/views/RoomActionsView/components/CallSection.test.tsxapp/containers/message/__tests__/index.test.tsxapp/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsx
📚 Learning: 2026-06-25T18:37:44.793Z
Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7434
File: app/views/ScreenLockConfigView.tsx:101-141
Timestamp: 2026-06-25T18:37:44.793Z
Learning: In the Rocket.Chat React Native codebase, do not treat passing an `async` function directly to an event prop in React/React Native UI components (e.g., `onPress={async () => ...}` in TSX) as a “floating promises” CI-blocking lint issue—this repo does not enable the ESLint `no-floating-promises` rule (while `no-void` is enforced). Only raise robustness follow-ups when there are genuinely unhandled promise paths (e.g., fire-and-forget calls like `save()` that return a Promise that is neither awaited nor handled), and prefer making sure failure paths are explicitly handled/reported rather than blocking on lint-style floating-promise concerns.
Applied to files:
app/containers/message/hooks/__tests__/useMessageAccessibilityHint.test.tsxapp/containers/message/components/__tests__/Thread.test.tsxapp/views/CannedResponsesListView/CannedResponseItem.tsxapp/containers/message/components/__tests__/RepliedThread.test.tsxapp/views/RoomInfoEditView/index.tsxapp/containers/UIKit/MessageBlock.tsxapp/containers/message/components/__tests__/Reply.test.tsxapp/views/RoomInfoView/components/RoomInfoButtons.stories.tsxapp/containers/message/components/__tests__/Quote.test.tsxapp/containers/CustomIcon/index.tsxapp/containers/MessageComposer/MessageComposer.test.tsxapp/containers/message/stores/__tests__/MessageStore.test.tsxapp/containers/LoginServices/LoginServices.test.tsxapp/containers/message/components/__tests__/Content.test.tsxapp/containers/TextInput/FormTextInput.tsxapp/views/RoomInfoView/components/RoomInfoButtons.test.tsxapp/views/RoomView/List/hooks/useMessages.test.tsxapp/views/AddChannelTeamView.tsxapp/containers/message/components/__tests__/Blocks.test.tsxapp/views/RoomView/List/index.tsxapp/views/RoomView/index.tsxapp/containers/MessageComposer/MessageComposer.tsxapp/containers/ActionSheet/ActionSheet.tsxapp/views/RoomActionsView/components/CallSection.stories.tsxapp/containers/message/hooks/__tests__/useMessageAccessibilityLabel.test.tsxapp/views/ModalBlockView.tsxapp/views/RoomActionsView/components/CallSection.test.tsxapp/containers/message/__tests__/index.test.tsxapp/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsx
📚 Learning: 2026-06-24T22:58:43.390Z
Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7157
File: app/views/MessagesView/index.tsx:392-392
Timestamp: 2026-06-24T22:58:43.390Z
Learning: When wrapping a React Native component (e.g., via `withSafeAreaInsets`) ensure `hoistNonReactStatics` is only required if the wrapped component actually defines static properties/methods that consumers rely on. If the component has no statics (as in `app/views/MessagesView/index.tsx`), you can omit `hoistNonReactStatics` for this case.
Applied to files:
app/views/CannedResponsesListView/CannedResponseItem.tsxapp/views/RoomInfoEditView/index.tsxapp/views/RoomInfoView/components/RoomInfoButtons.stories.tsxapp/views/RoomInfoView/components/RoomInfoButtons.test.tsxapp/views/RoomView/List/hooks/useMessages.test.tsxapp/views/AddChannelTeamView.tsxapp/views/RoomView/List/index.tsxapp/views/RoomView/index.tsxapp/views/RoomActionsView/components/CallSection.stories.tsxapp/views/ModalBlockView.tsxapp/views/RoomActionsView/components/CallSection.test.tsx
📚 Learning: 2026-03-15T13:55:42.038Z
Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6911
File: app/containers/markdown/Markdown.stories.tsx:104-104
Timestamp: 2026-03-15T13:55:42.038Z
Learning: In Rocket.Chat React Native, the markdown parser requires a space between the underscore wrapping italic text and a mention sigil (_ mention _ instead of _mention_). Ensure stories and tests that include italic-wrapped mentions follow this form to guarantee proper parsing. Specifically, for files like app/containers/markdown/Markdown.stories.tsx, and any test/content strings that exercise italic-mentions, use the pattern _ mention _ (with spaces) to prevent the mention from being treated as plain text. Validate any test strings or story content accordingly.
Applied to files:
app/views/RoomInfoView/components/RoomInfoButtons.stories.tsxapp/views/RoomActionsView/components/CallSection.stories.tsx
📚 Learning: 2026-06-26T19:40:06.327Z
Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7449
File: app/containers/ActionSheet/useActionSheetItemHeight.ts:0-0
Timestamp: 2026-06-26T19:40:06.327Z
Learning: In Rocket.Chat’s React Native ActionSheet implementation, avoid introducing a dependency on the responsive-layout provider (useResponsiveLayout) for ActionSheet sizing. In ActionSheet-related files (e.g., app/containers/ActionSheet/useActionSheetItemHeight.ts), it’s acceptable to read `fontScale` directly from `useWindowDimensions()` when it would yield the identical value; only couple to `useResponsiveLayout` if `useWindowDimensions().fontScale` would differ and would affect sizing.
Applied to files:
app/containers/ActionSheet/ActionSheet.tsx
📚 Learning: 2026-02-05T13:55:00.974Z
Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6930
File: package.json:101-101
Timestamp: 2026-02-05T13:55:00.974Z
Learning: In this repository, the dependency on react-native-image-crop-picker should reference the RocketChat fork (RocketChat/react-native-image-crop-picker) with explicit commit pins, not the upstream ivpusic/react-native-image-crop-picker. Update package.json dependencies (and any lockfile) to point to the fork URL and a specific commit, ensuring edge-to-edge Android fixes are included. This pattern should apply to all package.json files in the repo that declare this dependency.
Applied to files:
package.json
📚 Learning: 2026-05-07T17:47:14.516Z
Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7303
File: package.json:5-5
Timestamp: 2026-05-07T17:47:14.516Z
Learning: When reviewing pnpm `packageManager` version pins in any `package.json` (e.g., `"packageManager": "pnpm@<version>"`), don’t rely solely on web-search results to determine whether a version exists. For very recently published versions, cross-check the target version against the official pnpm release page (https://github.com/pnpm/pnpm/releases) and the npm registry page for pnpm (https://www.npmjs.com/package/pnpm) before flagging the pinned version as non-existent.
Applied to files:
package.json
🔇 Additional comments (47)
.maestro/scripts/data-setup.js (1)
73-73: LGTM!app/views/RoomView/List/hooks/useScroll.ts (1)
154-154: LGTM!Also applies to: 229-229
app/views/RoomInfoEditView/index.tsx (1)
457-457: LGTM!app/containers/TextInput/FormTextInput.tsx (1)
176-180: LGTM!.rnstorybook/generateSnapshots.tsx (1)
1-1: LGTM!Also applies to: 17-17
app/containers/message/components/__tests__/Thread.test.tsx (1)
17-17: LGTM!app/containers/message/hooks/__tests__/useMessageAccessibilityHint.test.tsx (1)
11-11: LGTM!app/containers/message/hooks/__tests__/useMessageAccessibilityLabel.test.tsx (1)
27-27: LGTM!app/lib/methods/loadMessagesForRoom.test.ts (1)
47-47: LGTM!app/lib/methods/search.test.ts (1)
77-77: LGTM!app/lib/services/voip/MediaSessionInstance.test.ts (1)
173-187: LGTM!app/views/RoomActionsView/components/CallSection.stories.tsx (1)
46-46: LGTM!app/views/RoomActionsView/components/CallSection.test.tsx (1)
79-79: LGTM!app/views/RoomInfoView/components/RoomInfoButtons.stories.tsx (1)
46-46: LGTM!app/views/RoomInfoView/components/RoomInfoButtons.test.tsx (1)
63-63: LGTM!.rnstorybook/main.ts (1)
1-1: LGTM!app/containers/ActionSheet/ActionSheet.tsx (1)
125-125: LGTM!app/containers/CustomIcon/index.tsx (1)
17-17: LGTM!app/containers/MessageComposer/MessageComposer.tsx (1)
117-117: LGTM!app/containers/MessageComposer/hooks/useAutocomplete.ts (1)
31-33: LGTM!app/containers/UIKit/MessageBlock.tsx (1)
4-8: LGTM!app/definitions/ILoggedUser.ts (1)
33-36: LGTM!app/definitions/ITeam.ts (1)
51-54: LGTM!app/definitions/rest/helpers/index.ts (1)
7-10: LGTM!Also applies to: 32-32, 52-57
app/containers/message/__tests__/index.test.tsx (1)
57-57: LGTM!app/containers/message/components/__tests__/Blocks.test.tsx (1)
17-17: LGTM!app/definitions/utils.ts (1)
18-20: LGTM!app/lib/database/interfaces.ts (1)
27-50: LGTM!Also applies to: 65-68
app/lib/methods/helpers/mergeSubscriptionsRooms.ts (1)
54-54: LGTM!app/lib/methods/roomTypeToApiType.ts (1)
12-17: LGTM!app/views/ModalBlockView.tsx (1)
163-170: LGTM!app/views/RoomView/List/index.tsx (1)
60-60: LGTM!app/views/RoomView/index.tsx (1)
1239-1239: LGTM!app/containers/message/components/__tests__/Quote.test.tsx (1)
44-44: LGTM!app/containers/message/components/__tests__/RepliedThread.test.tsx (1)
11-12: LGTM!app/containers/message/components/__tests__/Reply.test.tsx (1)
48-53: LGTM!app/lib/services/restApi.ts (1)
267-267: LGTM!app/lib/services/voip/getPeerAutocompleteOptions.ts (1)
48-48: LGTM!app/reducers/login.ts (1)
106-106: LGTM!app/views/AddChannelTeamView.tsx (1)
74-78: LGTM!app/views/CannedResponsesListView/CannedResponseItem.tsx (1)
55-55: LGTM!app/containers/LoginServices/LoginServices.test.tsx (1)
42-42: LGTM!app/containers/MessageComposer/MessageComposer.test.tsx (1)
95-95: LGTM!app/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsx (1)
219-270: LGTM!app/containers/message/components/__tests__/Content.test.tsx (1)
51-51: LGTM!app/containers/message/stores/__tests__/MessageStore.test.tsx (1)
166-172: LGTM!app/views/RoomView/List/hooks/useMessages.test.tsx (1)
63-63: LGTM!
diegolmello
had a problem deploying
to
upload_android
July 24, 2026 20:46 — with
GitHub Actions
Error
GitHub Actions
Error
|
Android Build Available Rocket.Chat 4.75.0.109409 Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNTT6uRhkKGuneNSW2aNuA4lStOmQYTtUeQk8HTym48h8evHNnRRwtVF7yqJJoDUhRD2dz_ebBhynjUGBPct |
|
iOS Build Available Rocket.Chat 4.75.0.109410 |
diegolmello
had a problem deploying
to
upload_android
July 24, 2026 21:05 — with
GitHub Actions
Error
GitHub Actions
Error
diegolmello
requested a deployment
to
approve_e2e_testing
July 24, 2026 21:18 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
diegolmello
requested a deployment
to
android_build
July 24, 2026 21:21 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit
Chores
Documentation
Bug Fixes