SDL

[philocalyst]

No description provided.

[ohlidalp]

I took the liberty to rebase & force-push, adding minor fixes (to fixup later).
So far I tested keyboard & mouse only - I found minor issues:

• keyboard navigation in main/pause menu isn't working.
• in the actor-loader UI, the list navigation and Enter confirmation doesn't work. Typing to searchbox works, though.
• 3rd person camera orbiting doesn't work. That's on me, the camera manager is awful.
• 1st person cinecam movement doesn't work. Likely the same issue.

[philocalyst]

THINK the new commit is a fix, will you push changes for the camera work?

[ohlidalp]

Keys are fixed: menu navigations, Enter/Backspace in input boxes, all works.

I've looked to the camera and it turns out SDL_GetMouseState() constantly returns zero. imgui only works because it uses OgreBites events to inject mouse buttons.

I've also hooked my vintage Thrustmaster T100 wheel and... SDL_JoystickGetAxis() returns bogus values. The 'Thrustmaster Control Panel' works OK though.

I'm seeing a pattern here... at least under Windows10 x64 using sdl/2.30.9 we can't rely on direct input querying and have to listen to OgreBites events exclusively. I take it that under your system at least the mouse camera orbit worked?

Update: SDL_InitSubSystem(SDL_INIT_JOYSTICK | SDL_INIT_HAPTIC) returns 0, so joystick should work.

[philocalyst]

I'm seeing a pattern here... at least under Windows10 x64 using sdl/2.30.9 we can't rely on direct input querying and have to listen to OgreBites events exclusively. I take it that under your system at least the mouse camera orbit worked?

It did!

So where does this leave us on the PR?

[ohlidalp]

I've worked around the mouse buttons by caching states from events.

Next, we need to scavenge for info.

• There's nothing about using SDL directly in the docs:https://ogrecave.github.io/ogre/api/latest/group___input.html
• There seem to be nothing related in issue tracker, either: https://github.com/OGRECave/ogre/issues?q=is%3Aissue%20*SDL*
• SDL2 wiki also doesn't show any warnings: https://wiki.libsdl.org/SDL2/SDL_GetMouseState

I need to create some test app with just OGRE+SDL and see if it works there. It may be RoR, but it may be windows, too.

[ohlidalp]

Conclusion... it works when done right.
I built OGRE 14.5.2 from source and modified it's 'CharacterSample' to display mouse buttons via SDL_GetMouseState(). I used the same include and lib that OGRE was built against (I built with 'OGRE_BUILD_DEPENDENCIES=ON').
The image below shows a diff with all my edits... I didn't touch SDL_InitSubSystem() at all.

[ohlidalp]

@AnotherFoxGuy How can I make sure there's no mixup happening between OGRE conan package and my game devbuild?
I looked into the conanfile and it seems it should match:

• conan cache path ogre3d/14.5.2@anotherfoxguy/stable returned "C:\Users\ohlidalp.conan2\p\ogre3903876674e29f\e"
• the conanfile.py says self.requires("sdl/[~2]")
• conan list *sdl* returns just "sdl/2.30.9" so I assume it got used for both.

I didn't find a way to match a conan build dir to a package, so by trial and error I landed at "c:\Users\ohlidalp.conan2\p\b\ogre3900a2f6d0d7de\b\build" which shows "14-5-2" in 'version.txt'

• I opened the OGRE.sln ... strangely OgreBites.vcxproj didn't have SDL2 in 'Linker/Input/Additional Dependencies' at all.
• my OGRE build has SDL2.dll in /bin subdir of builddir, the conan build doesn't. Maybe the problem is static/dynamic linkage.
• CMakeCache in the conan build showed
  //The directory containing a CMake configuration file for SDL2. SDL2_DIR:PATH=C:/Users/ohlidalp/.conan2/p/b/ogre3900a2f6d0d7de/b/build/generators and the 'SDL2Targets.cmake' suggested there are 3 possible targets: SDL2::SDL2main, SDL2::SDL2-static and SDL2::SDL2
• I fulltexted my OGRE devbuild dirs (built with 'OGRE_BUILD_DEPENDENCIES=ON') and found this under 'builddir/Dependencies/cmake':

---- SDL2mainTargets.cmake ----
# Create imported target SDL2::SDL2main
add_library(SDL2::SDL2main STATIC IMPORTED)

set_target_properties(SDL2::SDL2main PROPERTIES
  COMPATIBLE_INTERFACE_STRING "SDL_VERSION"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include;${_IMPORT_PREFIX}/include/SDL2"
  INTERFACE_LINK_LIBRARIES "\$<LINK_ONLY:shell32>"
  INTERFACE_SDL_VERSION "SDL2"
)
---- SDL2Targets.cmake ----
# Create imported target SDL2::SDL2
add_library(SDL2::SDL2 SHARED IMPORTED)

set_target_properties(SDL2::SDL2 PROPERTIES
  COMPATIBLE_INTERFACE_BOOL "SDL2_SHARED"
  COMPATIBLE_INTERFACE_STRING "SDL_VERSION"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include;${_IMPORT_PREFIX}/include/SDL2"
  INTERFACE_SDL2_SHARED "TRUE"
  INTERFACE_SDL_VERSION "SDL2"
)
---- SDLConfig.cmake ----
# Create SDL2::SDL2 alias for static-only builds
if(TARGET SDL2::SDL2-static AND NOT TARGET SDL2::SDL2)
    add_library(SDL2::SDL2 ALIAS SDL2::SDL2-static)

Finally I opened RoR project properties and saw this:

C:\Users\ohlidalp\.conan2\p\b\sdl2b5f435e448f5\p\lib\SDL2maind.lib
C:\Users\ohlidalp\.conan2\p\b\sdl2b5f435e448f5\p\lib\SDL2-staticd.lib

Removing 'maind' had no effect. Removing '-staticd' caused linking errors because apparently the headers I'm pulling in (C:\Users\ohlidalp.conan2\p\b\sdl2b5f435e448f5\p\include\SDL2\SDL_mouse.h) don't have __declspec(dllimport) on them (the DECLSPEC macro is empty).

Also https://github.com/libsdl-org/SDL/blob/main/docs/README-dynapi.md linked from https://wiki.libsdl.org/SDL2/Installation.

Complicated stuff.

@philocalyst For the time being, I say let's fall back to using OgreBites input events for everything. We may have to cache some inputs locally which isn't ellegant and we'll lose forcefeedback/haptics, but that can be done later.