Add: Refactor requirements doc#383
Draft
suspect15 wants to merge 1 commit into
Draft
Conversation
redwizard42
reviewed
Jun 15, 2026
|
|
||
| - Bracketed size at the beginning of every note, may include BE or BCD as appropriate [16-bit BE], [16-bit BCD], [16-bit BE BCD] | ||
| - Bitflags shall not be bracketed, but may be included in the note description, not required though as seeing values as bits makes it clear that the address contains bitflags | ||
| - Address description in clear, concise verbiage - may expand as needed, but should not unnecessarily |
Contributor
There was a problem hiding this comment.
sentence here ends abruptly and feels like more words should follow "but should not unnecessarily"
I think the intent from context is to not unnecessarily expand description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a requirements doc for refactored inactive developer sets. The purpose of this is to establish a standard for bringing substandard, inactive developer sets up to current quality standards to ensure long term stability and easiest possible future maintenance.