Add marker region decorator#29
Open
max-models wants to merge 6 commits into
Open
Conversation
Member
|
Sounds like a good idea to use decorators. |
Contributor
Author
I think it is. Actually, I already did something similar in a separate project where I basically wrapped the pylikwid marker start and stop like this: https://github.com/max-models/scope-profiler/blob/devel/src/scope_profiler/region_profiler.py#L303-L341 There, I profile regions using pylikwid either with a decorator or a context manager so for example: with ProfileManager.profile_region("my_function"):
call_func() |
Member
|
Do you think this PR can be merged? |
Contributor
Author
Yes! To me it's finished :) Let me know if you need me to change anything. I just updated the readme and merged the last updates of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a
@profiledecorator so that functions can be profiled withor
instead of using
pylikwid.markerstartregion("work")andpylikwid.markerstopregion("work")This PR branches from #28 , so if you want to merge this, then we should do it after merging #28 .