-
Notifications
You must be signed in to change notification settings - Fork 2.6k
perf(cli): defer startup prefetch tasks #6303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
water-in-stone
wants to merge
15
commits into
QwenLM:main
Choose a base branch
from
water-in-stone:perf/speed-start
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9c472cf
perf(cli): defer startup prefetch tasks
66b9b0b
fix(cli): await IDE for prompt-interactive startup
5f8036b
perf(cli): defer interactive telemetry startup
e441f64
test(cli): add missing assertions and Zed/ACP path coverage for start…
9e67e80
docs: move startup prefetch design doc to performance subdirectory
1957471
docs: translate startup prefetch design doc to English
006935b
fix(cli): address startup prefetch review comments
3257422
fix(cli): initialize telemetry for prompt-interactive prompts
d311854
Merge branch 'main' into perf/speed-start
water-in-stone 64119f7
Merge branch 'main' into perf/speed-start
water-in-stone be22286
Merge branch 'main' into perf/speed-start
03467db
Merge branch 'main' into perf/speed-start
6cba2c5
fix(cli): preserve startup first-request guarantees
d053590
fix(cli): make post-render IDE connection opt-in
02e5be8
Merge branch 'main' into perf/speed-start
water-in-stone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
369 changes: 369 additions & 0 deletions
369
docs/design/performance/fire-and-forget-startup-prefetch.md
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] This test verifies
deferTelemetryInitialization: falsefor prompt-interactive, but there is no corresponding positive test verifyingdeferTelemetryInitialization: truefor the ordinary interactive case (no-p, no-i "prompt", not ACP). The positive path is the primary motivation for the feature — deferring telemetry for ordinary TUI startup — yet it has no test. A regression that accidentally always setsfalsewould go undetected.Consider adding a test with
process.argv = ['node', 'script.js', '-i'](interactive, no question) that assertsdeferTelemetryInitialization: true.— qwen3.7-max via Qwen Code /review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in
6cba2c578.Added a positive
loadCliConfigtest for ordinary interactive startup that setsprocess.stdin.isTTY = true, uses no initial prompt, and assertsdeferTelemetryInitialization: trueis passed toConfig.