-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat(core): add Tool(param:value) permission syntax for parameter-level access control #6106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
b39d2a0
feat(core): add Tool(param:value) permission syntax for parameter-lev…
DennisYu07 37a4b63
Merge branch 'main' into feat/tool-param-permission-syntax
DennisYu07 8e59413
fix(permissions): resolve PR #6106 review comments for tool param per…
DennisYu07 afe0a2f
Merge branch 'main' into feat/tool-param-permission-syntax
DennisYu07 c440099
Merge branch 'main' into feat/tool-param-permission-syntax
DennisYu07 378ff95
Merge branch 'main' into feat/tool-param-permission-syntax
yiliang114 287bb58
Merge branch 'main' into feat/tool-param-permission-syntax
DennisYu07 e6b39f3
fix(core): address critical review feedback on Tool(param:value) perm…
DennisYu07 52f0151
Merge branch 'main' into feat/tool-param-permission-syntax
DennisYu07 aade36e
Merge branch 'main' into feat/tool-param-permission-syntax
DennisYu07 75997d3
Merge branch 'main' into feat/tool-param-permission-syntax
wenshao b026ffa
Merge branch 'main' into feat/tool-param-permission-syntax
wenshao 892e8be
Merge branch 'main' into feat/tool-param-permission-syntax
wenshao 89715c7
fix(permissions): address remaining review feedback for Tool(param:va…
DennisYu07 0adb27c
Merge branch 'main' into feat/tool-param-permission-syntax
DennisYu07 1960cd8
Merge branch 'main' into feat/tool-param-permission-syntax
wenshao fdbb222
Merge branch 'main' into feat/tool-param-permission-syntax
DennisYu07 cda1c29
Merge branch 'main' into feat/tool-param-permission-syntax
DennisYu07 2fecd2c
Merge branch 'main' into feat/tool-param-permission-syntax
DennisYu07 3b78d72
fix(permissions): address PR #6106 review comments and fix useStatusL…
DennisYu07 d1c2645
Merge branch 'main' into feat/tool-param-permission-syntax
DennisYu07 ed40d65
Merge branch 'main' into feat/tool-param-permission-syntax
DennisYu07 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] Missing test coverage for the MCP +
toolParamMatcherscombination inmatchesRule. The MCP branch (rule-parser.ts ~lines 1155-1183) was rewritten with three new sub-paths: specifier rejection, param matcher evaluation, and their combination — but no test exercises any of them throughmatchesRule.Recommended additions:
parseRule('mcp__server__tool(model:opus)')→matchesRulewith{model: 'opus'}should betrue{model: 'sonnet'}should befalsetoolParamsshould befalseparseRule('mcp__server__tool(feature_x)')(bare specifier) →matchesRuleshould befalse(specifier rejection)— qwen3.7-max via Qwen Code /review