-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat(config): add todosDirectory setting for project-local todo persistence #5928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1911,6 +1911,7 @@ export async function loadCliConfig( | |
| clearContextOnIdle: settings.context?.clearContextOnIdle, | ||
| fileFiltering: settings.context?.fileFiltering, | ||
| plansDirectory: settings.plansDirectory, | ||
| todosDirectory: settings.todosDirectory, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Suggestion] This is the only place where the real CLI settings object is wired into — GPT-5 via Qwen Code /review |
||
| proxy: | ||
| argv.proxy || | ||
| settings.proxy || | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -837,6 +837,7 @@ export interface ConfigParameters { | |
| fileCheckpointingEnabled?: boolean; | ||
| /** Directory where approved plan files are stored. Must resolve inside targetDir. */ | ||
| plansDirectory?: string; | ||
| todosDirectory?: string; | ||
| proxy?: string; | ||
| cwd: string; | ||
| fileDiscoveryService?: FileDiscoveryService; | ||
|
|
@@ -1435,6 +1436,7 @@ export class Config { | |
| private readonly jsonSchema: Record<string, unknown> | undefined; | ||
| private readonly inputFile: string | undefined; | ||
| private readonly plansDir: string; | ||
| private readonly todosDir: string; | ||
| private readonly plansDirectoryConfigured: boolean; | ||
| private readonly defaultFileEncoding: FileEncodingType | undefined; | ||
| private readonly enableManagedAutoMemory: boolean; | ||
|
|
@@ -1477,6 +1479,7 @@ export class Config { | |
| this.targetDir = path.resolve(params.targetDir); | ||
| this.plansDirectoryConfigured = Boolean(params.plansDirectory?.trim()); | ||
| this.plansDir = Storage.getPlansDir(this.targetDir, params.plansDirectory); | ||
| this.todosDir = Storage.getTodosDir(this.targetDir, params.todosDirectory); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Suggestion] When Suggest mirroring the plans warning — guard on a — claude-opus-4-8 via Claude Code /qreview
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Suggestion] Missing Config-level test coverage for The parallel A regression in the constructor (e.g., passing Consider adding two tests mirroring the plansDirectory ones:
— qwen3.7-max via Qwen Code /review |
||
| this.explicitIncludeDirectories = Array.from( | ||
| new Set(params.includeDirectories ?? []), | ||
| ); | ||
|
|
@@ -4103,6 +4106,10 @@ export class Config { | |
| return this.plansDir; | ||
| } | ||
|
|
||
| getTodosDir(): string { | ||
| return this.todosDir; | ||
| } | ||
|
|
||
| private assertPlansDirWithinTargetDir(): void { | ||
| if (!this.plansDirectoryConfigured) { | ||
| return; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] The parallel
plansDirectoryrow (line 465) ends with "add it to.gitignoreto avoid committing plan files." This row drops that guidance — yet the example at line 523 uses"todosDirectory": "./.qwen/todos"(inside the project root), which would commit per-session todo JSON (named by session UUID) into the repo.— claude-opus-4-8 via Claude Code /qreview