-
Notifications
You must be signed in to change notification settings - Fork 422
Allow allow subregional NUTS selection. #2146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bobbyxng
wants to merge
6
commits into
PyPSA:master
Choose a base branch
from
resilient-project:subregions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
abe409a
Allow allow subregional NUTS selection.
bobbyxng abfd30b
Updated schema.
bobbyxng 2c737b2
Schema update.
bobbyxng 8039534
Refactored code.
bobbyxng c8f5a4a
Ruff formatted.
bobbyxng afdd052
Merge branch 'master' into subregions
bobbyxng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1469,30 +1469,43 @@ def build_admin_shapes( | |
|
|
||
| if clustering == "administrative": | ||
| logger.info(f"Building bus regions at administrative level {level}") | ||
|
|
||
| nuts3_regions["column"] = level_map[level] | ||
|
|
||
| # Only keep the values whose keys are in countries | ||
| countries_config = admin_levels.get("countries", {}) | ||
| country_level = { | ||
| k: v for k, v in admin_levels.items() if (k != "level") and (k in countries) | ||
| k: v for k, v in countries_config.items() if len(k) == 2 and k in countries | ||
| } | ||
| subregion_level = { | ||
| k: v | ||
| for k, v in countries_config.items() | ||
| if len(k) > 2 and k[:2] in countries | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does that also work for the UK, where it shows up as |
||
| } | ||
|
|
||
| if country_level: | ||
| country_level_list = "\n".join( | ||
| [f"- {k}: level {v}" for k, v in country_level.items()] | ||
| ) | ||
| logger.info( | ||
| f"Setting individual administrative levels for:\n{country_level_list}" | ||
| "Setting individual administrative levels for:\n" | ||
| + "\n".join(f"- {k}: level {v}" for k, v in country_level.items()) | ||
| ) | ||
| nuts3_regions.loc[ | ||
| nuts3_regions["country"].isin(country_level.keys()), "column" | ||
| nuts3_regions["country"].isin(country_level), "column" | ||
| ] = ( | ||
| nuts3_regions.loc[ | ||
| nuts3_regions["country"].isin(country_level.keys()), "country" | ||
| nuts3_regions["country"].isin(country_level), "country" | ||
| ] | ||
| .map(country_level) | ||
| .map(level_map) | ||
| ) | ||
|
|
||
| if subregion_level: | ||
| logger.info( | ||
| "Setting individual administrative levels for subregions:\n" | ||
| + "\n".join(f"- {k}: level {v}" for k, v in subregion_level.items()) | ||
| ) | ||
| for k, v in subregion_level.items(): | ||
| nuts3_regions.loc[nuts3_regions.index.str.startswith(k), "column"] = ( | ||
| level_map[v] | ||
| ) | ||
|
|
||
| # If GB is in the countries, set the level, aggregate London area to level 1 due to converging issues | ||
| if "GB" in countries and level != "bz": | ||
| nuts3_regions.loc[nuts3_regions.level1 == "GBI", "column"] = "level1" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it still be necessary to filter out the "level" here? Why can it be removed?