Skip to content

Rename form_type column name - #1862

Merged
Quetzacoalt91 merged 1 commit into
PrestaShop:7.6.xfrom
jolelievre:rename-form-type
Jul 7, 2026
Merged

Rename form_type column name#1862
Quetzacoalt91 merged 1 commit into
PrestaShop:7.6.xfrom
jolelievre:rename-form-type

Conversation

@jolelievre

Copy link
Copy Markdown
Contributor
Questions Answers
Description? Rename form_type column name
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? PrestaShop/PrestaShop#41967
Sponsor company ~
How to test? ~

@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

@Quetzacoalt91 Quetzacoalt91 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jolelievre you're modifying the file 9.2.0.sql here while the Core pull-request refers has the milestone 9.3.0. Please confirm what should be changed.

@jolelievre

Copy link
Copy Markdown
Contributor Author

@Quetzacoalt91 yep the modif here is right, the modification was already merged in develop and will be part of the 9.2 I updated the milestone

@ps-jarvis ps-jarvis added the Waiting for QA Status: Action required, Waiting for test feedback label Jul 6, 2026
@ps-jarvis ps-jarvis moved this from Ready for review to To be tested in PR Dashboard Jul 6, 2026
@Quetzacoalt91 Quetzacoalt91 added this to the 7.6.6 milestone Jul 6, 2026
@Quetzacoalt91

Copy link
Copy Markdown
Member
  • 🟢 Column rename applied correctly. The upgrade log shows the 9.2.0 migration executing CREATE TABLE ps_extra_property_definition (... form_type varchar(255) ...) without error. The full schema diff (upgraded vs. fresh install) shows form_type present identically on both sides. The upgraded shop's schema now matches a fresh 9.2.0 install exactly for this table.
  • 🟢 No data-level regressions. extra_property_definition table diff is empty (table has no seeded data on either side, as expected for a new table).
  • 🟡 Unrelated pre-existing noise in the full schema diff: COLLATE annotations differ (utf8mb4_unicode_ci explicit vs. implicit) across dozens of unrelated columns in the whole DB. However this is a known mysqldump-version artifact, not a real issue (per the checklist, ignored since both sides are utf8mb4).

@ingridusta ingridusta self-assigned this Jul 7, 2026

@ingridusta ingridusta left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jolelievre,

Column name is updated as expected after an update to 9.2.x :

Image

It's QA approved ✅

@ingridusta ingridusta added QA ✔️ Status: Check done, Code approved and removed Waiting for QA Status: Action required, Waiting for test feedback labels Jul 7, 2026
@Quetzacoalt91
Quetzacoalt91 merged commit 07c1c76 into PrestaShop:7.6.x Jul 7, 2026
97 of 100 checks passed
@github-project-automation github-project-automation Bot moved this from To be tested to Merged in PR Dashboard Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Migration script QA ✔️ Status: Check done, Code approved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants