Skip to content

Introduce stubs to avoid unstable code from PrestaShop while an update is running - #1857

Merged
Quetzacoalt91 merged 5 commits into
PrestaShop:7.6.xfrom
Quetzacoalt91:stub-core-services
Jul 2, 2026
Merged

Introduce stubs to avoid unstable code from PrestaShop while an update is running#1857
Quetzacoalt91 merged 5 commits into
PrestaShop:7.6.xfrom
Quetzacoalt91:stub-core-services

Conversation

@Quetzacoalt91

@Quetzacoalt91 Quetzacoalt91 commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
Questions Answers
Description? #1850 introduces the extra properties on PrestaShop. When updating to this versions, the files are applied before updating the database. Unfortunately, some actions such as module installation causes the Core to load some ObjectModel instances and the extra properties with them. Because the database is not ready until the migration of 9.2.0 is applied, the process will fail saying a table is missing. This PR introduces some stubs for the core, which will catch the exception until the table is created.
Type? new feature
BC breaks? Nope
Deprecations? Nope
Fixed ticket? Fixes #1850 (comment)
Sponsor company @PrestaShopCorp
How to test? Updates to PrestaShop 9.2.0 aren't failing anymore because of this exception: Base table or view not found: 1146 Table 'presta_827.ps_extra_property_definition' doesn't exist 
[2026-07-01 19:19:09] DEBUG - ChainedTasks - Step UpdateDatabase
[2026-07-01 19:19:09] INFO - UpdateDatabase - Mise à jour de la base de données en cours. 89 requêtes restantes
[2026-07-01 19:19:09] WARNING - FaultTolerantExtraPropertyDefinitionRepository - FaultTolerantExtraPropertyDefinitionRepository: caught exception while fetching all definitions: An exception occurred while executing a query: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'psreference.ks_extra_property_definition' doesn't exist
[2026-07-01 19:19:09] ERROR - UpdateCommand - An error occurred during the update process:
PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'psreference.ks_extra_property_definition' doesn't exist in /var/www/html/vendor/doctrine/dbal/src/Driver/PDO/Connection.php:71
Stack trace:
#0 /var/www/html/vendor/doctrine/dbal/src/Driver/PDO/Connection.php(71): PDO->query('SELECT eef.* FR...')
#1 /var/www/html/vendor/doctrine/dbal/src/Connection.php(1101): Doctrine\DBAL\Driver\PDO\Connection->query('SELECT eef.* FR...')
#2 /var/www/html/vendor/doctrine/dbal/src/Query/QueryBuilder.php(348): Doctrine\DBAL\Connection->executeQuery('SELECT eef.* FR...', Array, Array, NULL)
#3 /var/www/html/src/Core/ExtraProperty/Definition/ExtraPropertyDefinitionRepository.php(45): Doctrine\DBAL\Query\QueryBuilder->executeQuery()
#4 /var/www/html/src/Core/ExtraProperty/Definition/CachedExtraPropertyDefinitionRepository.php(57): PrestaShop\PrestaShop\Core\ExtraProperty\Definition\ExtraPropertyDefinitionRepository->getAllDefinitions()
#5 /var/www/html/vendor/symfony/cache/LockRegistry.php(113): PrestaShop\PrestaShop\Core\ExtraProperty\Definition\CachedExtraPropertyDefinitionRepository->PrestaShop\PrestaShop\Core\ExtraProperty\Definition\{closure}(Object(Symfony\Component\Cache\CacheItem), true)
#6 /var/www/html/vendor/symfony/cache/Traits/ContractsTrait.php(102): Symfony\Component\Cache\LockRegistry::compute(Object(Closure), Object(Symfony\Component\Cache\CacheItem), true, Object(Symfony\Component\Cache\Adapter\FilesystemAdapter), Object(Closure), NULL, 1.0)
#7 /var/www/html/vendor/symfony/cache-contracts/CacheTrait.php(67): Symfony\Component\Cache\Adapter\AbstractAdapter->Symfony\Component\Cache\Traits\{closure}(Object(Symfony\Component\Cache\CacheItem), true)
#8 /var/www/html/vendor/symfony/cache/Traits/ContractsTrait.php(111): Symfony\Component\Cache\Adapter\AbstractAdapter->contractsGet(Object(Symfony\Component\Cache\Adapter\FilesystemAdapter), 'extra_property_...', Object(Closure), 1.0, Array, NULL)
#9 /var/www/html/vendor/symfony/cache-contracts/CacheTrait.php(30): Symfony\Component\Cache\Adapter\AbstractAdapter->doGet(Object(Symfony\Component\Cache\Adapter\FilesystemAdapter), 'extra_property_...', Object(Closure), 1.0, Array)
#10 /var/www/html/src/Core/ExtraProperty/Definition/CachedExtraPropertyDefinitionRepository.php(58): Symfony\Component\Cache\Adapter\AbstractAdapter->get('extra_property_...', Object(Closure))
#11 /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreServiceStub/Stubs/FaultTolerantExtraPropertyDefinitionRepository.php(67): PrestaShop\PrestaShop\Core\ExtraProperty\Definition\CachedExtraPropertyDefinitionRepository->getAllDefinitions()
#12 /var/www/html/classes/ObjectModel.php(2277): PrestaShop\Module\AutoUpgrade\UpgradeTools\CoreUpgrader\CoreServiceStub\Stubs\FaultTolerantExtraPropertyDefinitionRepository->getAllDefinitions()
#13 /var/www/html/classes/ObjectModel.php(1091): ObjectModelCore->getDefinitionCollection()
#14 /var/www/html/classes/ObjectModel.php(557): ObjectModelCore->validateExtraProperties()
#15 /var/www/html/classes/PrestaShopLogger.php(170): ObjectModelCore->add()
#16 /var/www/html/classes/module/Module.php(377): PrestaShopLoggerCore::addLog('Starting module...', 1, NULL, 'Module', NULL, true)
#17 /var/www/html/modules/autoupgrade/upgrade/php/install_ps_apiresources.php(24): ModuleCore->install()
#18 [internal function]: install_ps_apiresources()
#19 /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php(432): call_user_func_array('install_ps_apir...', Array)
#20 /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php(359): PrestaShop\Module\AutoUpgrade\UpgradeTools\CoreUpgrader\CoreUpgrader->runPhpQuery('9.0.0', '/* PHP:install_...')
#21 /var/www/html/modules/autoupgrade/classes/Task/Update/UpdateDatabase.php(178): PrestaShop\Module\AutoUpgrade\UpgradeTools\CoreUpgrader\CoreUpgrader->runQuery('9.0.0', '/* PHP:install_...')
#22 /var/www/html/modules/autoupgrade/classes/Task/Update/UpdateDatabase.php(61): PrestaShop\Module\AutoUpgrade\Task\Update\UpdateDatabase->updateDatabase(Object(PrestaShop\Module\AutoUpgrade\Progress\Backlog))
#23 /var/www/html/modules/autoupgrade/classes/Task/Runner/ChainedTasks.php(66): PrestaShop\Module\AutoUpgrade\Task\Update\UpdateDatabase->run()
#24 /var/www/html/modules/autoupgrade/classes/Commands/UpdateCommand.php(129): PrestaShop\Module\AutoUpgrade\Task\Runner\ChainedTasks->run()
#25 /var/www/html/modules/autoupgrade/sub-vendors/php8/vendor/symfony/console/Command/Command.php(326): PrestaShop\Module\AutoUpgrade\Commands\UpdateCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#26 /var/www/html/modules/autoupgrade/sub-vendors/php8/vendor/symfony/console/Application.php(1078): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#27 /var/www/html/modules/autoupgrade/sub-vendors/php8/vendor/symfony/console/Application.php(324): Symfony\Component\Console\Application->doRunCommand(Object(PrestaShop\Module\AutoUpgrade\Commands\UpdateCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#28 /var/www/html/modules/autoupgrade/sub-vendors/php8/vendor/symfony/console/Application.php(175): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#29 /var/www/html/modules/autoupgrade/bin/console(74): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#30 {main}

Next Doctrine\DBAL\Driver\PDO\Exception: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'psreference.ks_extra_property_definition' doesn't exist in /var/www/html/vendor/doctrine/dbal/src/Driver/PDO/Exception.php:28
Stack trace:
#0 /var/www/html/vendor/doctrine/dbal/src/Driver/PDO/Connection.php(76): Doctrine\DBAL\Driver\PDO\Exception::new(Object(PDOException))
#1 /var/www/html/vendor/doctrine/dbal/src/Connection.php(1101): Doctrine\DBAL\Driver\PDO\Connection->query('SELECT eef.* FR...')
#2 /var/www/html/vendor/doctrine/dbal/src/Query/QueryBuilder.php(348): Doctrine\DBAL\Connection->executeQuery('SELECT eef.* FR...', Array, Array, NULL)
#3 /var/www/html/src/Core/ExtraProperty/Definition/ExtraPropertyDefinitionRepository.php(45): Doctrine\DBAL\Query\QueryBuilder->executeQuery()
#4 /var/www/html/src/Core/ExtraProperty/Definition/CachedExtraPropertyDefinitionRepository.php(57): PrestaShop\PrestaShop\Core\ExtraProperty\Definition\ExtraPropertyDefinitionRepository->getAllDefinitions()
#5 /var/www/html/vendor/symfony/cache/LockRegistry.php(113): PrestaShop\PrestaShop\Core\ExtraProperty\Definition\CachedExtraPropertyDefinitionRepository->PrestaShop\PrestaShop\Core\ExtraProperty\Definition\{closure}(Object(Symfony\Component\Cache\CacheItem), true)
#6 /var/www/html/vendor/symfony/cache/Traits/ContractsTrait.php(102): Symfony\Component\Cache\LockRegistry::compute(Object(Closure), Object(Symfony\Component\Cache\CacheItem), true, Object(Symfony\Component\Cache\Adapter\FilesystemAdapter), Object(Closure), NULL, 1.0)
#7 /var/www/html/vendor/symfony/cache-contracts/CacheTrait.php(67): Symfony\Component\Cache\Adapter\AbstractAdapter->Symfony\Component\Cache\Traits\{closure}(Object(Symfony\Component\Cache\CacheItem), true)
#8 /var/www/html/vendor/symfony/cache/Traits/ContractsTrait.php(111): Symfony\Component\Cache\Adapter\AbstractAdapter->contractsGet(Object(Symfony\Component\Cache\Adapter\FilesystemAdapter), 'extra_property_...', Object(Closure), 1.0, Array, NULL)
#9 /var/www/html/vendor/symfony/cache-contracts/CacheTrait.php(30): Symfony\Component\Cache\Adapter\AbstractAdapter->doGet(Object(Symfony\Component\Cache\Adapter\FilesystemAdapter), 'extra_property_...', Object(Closure), 1.0, Array)
#10 /var/www/html/src/Core/ExtraProperty/Definition/CachedExtraPropertyDefinitionRepository.php(58): Symfony\Component\Cache\Adapter\AbstractAdapter->get('extra_property_...', Object(Closure))
#11 /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreServiceStub/Stubs/FaultTolerantExtraPropertyDefinitionRepository.php(67): PrestaShop\PrestaShop\Core\ExtraProperty\Definition\CachedExtraPropertyDefinitionRepository->getAllDefinitions()
#12 /var/www/html/classes/ObjectModel.php(2277): PrestaShop\Module\AutoUpgrade\UpgradeTools\CoreUpgrader\CoreServiceStub\Stubs\FaultTolerantExtraPropertyDefinitionRepository->getAllDefinitions()
#13 /var/www/html/classes/ObjectModel.php(1091): ObjectModelCore->getDefinitionCollection()
#14 /var/www/html/classes/ObjectModel.php(557): ObjectModelCore->validateExtraProperties()
#15 /var/www/html/classes/PrestaShopLogger.php(170): ObjectModelCore->add()
#16 /var/www/html/classes/module/Module.php(377): PrestaShopLoggerCore::addLog('Starting module...', 1, NULL, 'Module', NULL, true)
#17 /var/www/html/modules/autoupgrade/upgrade/php/install_ps_apiresources.php(24): ModuleCore->install()
#18 [internal function]: install_ps_apiresources()
#19 /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php(432): call_user_func_array('install_ps_apir...', Array)
#20 /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php(359): PrestaShop\Module\AutoUpgrade\UpgradeTools\CoreUpgrader\CoreUpgrader->runPhpQuery('9.0.0', '/* PHP:install_...')
#21 /var/www/html/modules/autoupgrade/classes/Task/Update/UpdateDatabase.php(178): PrestaShop\Module\AutoUpgrade\UpgradeTools\CoreUpgrader\CoreUpgrader->runQuery('9.0.0', '/* PHP:install_...')
#22 /var/www/html/modules/autoupgrade/classes/Task/Update/UpdateDatabase.php(61): PrestaShop\Module\AutoUpgrade\Task\Update\UpdateDatabase->updateDatabase(Object(PrestaShop\Module\AutoUpgrade\Progress\Backlog))
#23 /var/www/html/modules/autoupgrade/classes/Task/Runner/ChainedTasks.php(66): PrestaShop\Module\AutoUpgrade\Task\Update\UpdateDatabase->run()
#24 /var/www/html/modules/autoupgrade/classes/Commands/UpdateCommand.php(129): PrestaShop\Module\AutoUpgrade\Task\Runner\ChainedTasks->run()
#25 /var/www/html/modules/autoupgrade/sub-vendors/php8/vendor/symfony/console/Command/Command.php(326): PrestaShop\Module\AutoUpgrade\Commands\UpdateCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#26 /var/www/html/modules/autoupgrade/sub-vendors/php8/vendor/symfony/console/Application.php(1078): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#27 /var/www/html/modules/autoupgrade/sub-vendors/php8/vendor/symfony/console/Application.php(324): Symfony\Component\Console\Application->doRunCommand(Object(PrestaShop\Module\AutoUpgrade\Commands\UpdateCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#28 /var/www/html/modules/autoupgrade/sub-vendors/php8/vendor/symfony/console/Application.php(175): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#29 /var/www/html/modules/autoupgrade/bin/console(74): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#30 {main}

Next Doctrine\DBAL\Exception\TableNotFoundException: An exception occurred while executing a query: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'psreference.ks_extra_property_definition' doesn't exist in /var/www/html/vendor/doctrine/dbal/src/Driver/API/MySQL/ExceptionConverter.php:49
Stack trace:
#0 /var/www/html/vendor/doctrine/dbal/src/Connection.php(1939): Doctrine\DBAL\Driver\API\MySQL\ExceptionConverter->convert(Object(Doctrine\DBAL\Driver\PDO\Exception), Object(Doctrine\DBAL\Query))
#1 /var/www/html/vendor/doctrine/dbal/src/Connection.php(1881): Doctrine\DBAL\Connection->handleDriverException(Object(Doctrine\DBAL\Driver\PDO\Exception), Object(Doctrine\DBAL\Query))
#2 /var/www/html/vendor/doctrine/dbal/src/Connection.php(1106): Doctrine\DBAL\Connection->convertExceptionDuringQuery(Object(Doctrine\DBAL\Driver\PDO\Exception), 'SELECT eef.* FR...', Array, Array)
#3 /var/www/html/vendor/doctrine/dbal/src/Query/QueryBuilder.php(348): Doctrine\DBAL\Connection->executeQuery('SELECT eef.* FR...', Array, Array, NULL)
#4 /var/www/html/src/Core/ExtraProperty/Definition/ExtraPropertyDefinitionRepository.php(45): Doctrine\DBAL\Query\QueryBuilder->executeQuery()
#5 /var/www/html/src/Core/ExtraProperty/Definition/CachedExtraPropertyDefinitionRepository.php(57): PrestaShop\PrestaShop\Core\ExtraProperty\Definition\ExtraPropertyDefinitionRepository->getAllDefinitions()
#6 /var/www/html/vendor/symfony/cache/LockRegistry.php(113): PrestaShop\PrestaShop\Core\ExtraProperty\Definition\CachedExtraPropertyDefinitionRepository->PrestaShop\PrestaShop\Core\ExtraProperty\Definition\{closure}(Object(Symfony\Component\Cache\CacheItem), true)
#7 /var/www/html/vendor/symfony/cache/Traits/ContractsTrait.php(102): Symfony\Component\Cache\LockRegistry::compute(Object(Closure), Object(Symfony\Component\Cache\CacheItem), true, Object(Symfony\Component\Cache\Adapter\FilesystemAdapter), Object(Closure), NULL, 1.0)
#8 /var/www/html/vendor/symfony/cache-contracts/CacheTrait.php(67): Symfony\Component\Cache\Adapter\AbstractAdapter->Symfony\Component\Cache\Traits\{closure}(Object(Symfony\Component\Cache\CacheItem), true)
#9 /var/www/html/vendor/symfony/cache/Traits/ContractsTrait.php(111): Symfony\Component\Cache\Adapter\AbstractAdapter->contractsGet(Object(Symfony\Component\Cache\Adapter\FilesystemAdapter), 'extra_property_...', Object(Closure), 1.0, Array, NULL)
#10 /var/www/html/vendor/symfony/cache-contracts/CacheTrait.php(30): Symfony\Component\Cache\Adapter\AbstractAdapter->doGet(Object(Symfony\Component\Cache\Adapter\FilesystemAdapter), 'extra_property_...', Object(Closure), 1.0, Array)
#11 /var/www/html/src/Core/ExtraProperty/Definition/CachedExtraPropertyDefinitionRepository.php(58): Symfony\Component\Cache\Adapter\AbstractAdapter->get('extra_property_...', Object(Closure))
#12 /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreServiceStub/Stubs/FaultTolerantExtraPropertyDefinitionRepository.php(67): PrestaShop\PrestaShop\Core\ExtraProperty\Definition\CachedExtraPropertyDefinitionRepository->getAllDefinitions()
#13 /var/www/html/classes/ObjectModel.php(2277): PrestaShop\Module\AutoUpgrade\UpgradeTools\CoreUpgrader\CoreServiceStub\Stubs\FaultTolerantExtraPropertyDefinitionRepository->getAllDefinitions()
#14 /var/www/html/classes/ObjectModel.php(1091): ObjectModelCore->getDefinitionCollection()
#15 /var/www/html/classes/ObjectModel.php(557): ObjectModelCore->validateExtraProperties()
#16 /var/www/html/classes/PrestaShopLogger.php(170): ObjectModelCore->add()
#17 /var/www/html/classes/module/Module.php(377): PrestaShopLoggerCore::addLog('Starting module...', 1, NULL, 'Module', NULL, true)
#18 /var/www/html/modules/autoupgrade/upgrade/php/install_ps_apiresources.php(24): ModuleCore->install()
#19 [internal function]: install_ps_apiresources()
#20 /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php(432): call_user_func_array('install_ps_apir...', Array)
#21 /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php(359): PrestaShop\Module\AutoUpgrade\UpgradeTools\CoreUpgrader\CoreUpgrader->runPhpQuery('9.0.0', '/* PHP:install_...')
#22 /var/www/html/modules/autoupgrade/classes/Task/Update/UpdateDatabase.php(178): PrestaShop\Module\AutoUpgrade\UpgradeTools\CoreUpgrader\CoreUpgrader->runQuery('9.0.0', '/* PHP:install_...')
#23 /var/www/html/modules/autoupgrade/classes/Task/Update/UpdateDatabase.php(61): PrestaShop\Module\AutoUpgrade\Task\Update\UpdateDatabase->updateDatabase(Object(PrestaShop\Module\AutoUpgrade\Progress\Backlog))
#24 /var/www/html/modules/autoupgrade/classes/Task/Runner/ChainedTasks.php(66): PrestaShop\Module\AutoUpgrade\Task\Update\UpdateDatabase->run()
#25 /var/www/html/modules/autoupgrade/classes/Commands/UpdateCommand.php(129): PrestaShop\Module\AutoUpgrade\Task\Runner\ChainedTasks->run()
#26 /var/www/html/modules/autoupgrade/sub-vendors/php8/vendor/symfony/console/Command/Command.php(326): PrestaShop\Module\AutoUpgrade\Commands\UpdateCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#27 /var/www/html/modules/autoupgrade/sub-vendors/php8/vendor/symfony/console/Application.php(1078): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#28 /var/www/html/modules/autoupgrade/sub-vendors/php8/vendor/symfony/console/Application.php(324): Symfony\Component\Console\Application->doRunCommand(Object(PrestaShop\Module\AutoUpgrade\Commands\UpdateCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#29 /var/www/html/modules/autoupgrade/sub-vendors/php8/vendor/symfony/console/Application.php(175): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#30 /var/www/html/modules/autoupgrade/bin/console(74): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#31 {main}

@Quetzacoalt91 Quetzacoalt91 self-assigned this Jun 30, 2026
@Quetzacoalt91 Quetzacoalt91 added the new feature Type: New feature label Jun 30, 2026
@github-project-automation github-project-automation Bot moved this to Ready for review in PR Dashboard Jun 30, 2026
@Quetzacoalt91 Quetzacoalt91 changed the title Introduce stubs to avoid unstable code from PrestaShop while update is running Introduce stubs to avoid unstable code from PrestaShop while an update is running Jun 30, 2026
@Quetzacoalt91 Quetzacoalt91 added this to the 7.6.6 milestone Jun 30, 2026
@Quetzacoalt91 Quetzacoalt91 mentioned this pull request Jun 30, 2026
Merged
ga-devfront
ga-devfront approved these changes Jun 30, 2026
View reviewed changes

@ga-devfront ga-devfront left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legitimate but too much verbose

@ps-jarvis ps-jarvis added the Waiting for QA Status: Action required, Waiting for test feedback label Jun 30, 2026
@ps-jarvis ps-jarvis moved this from Ready for review to To be tested in PR Dashboard Jun 30, 2026
@ingridusta ingridusta self-assigned this Jun 30, 2026
ingridusta
ingridusta requested changes Jun 30, 2026
View reviewed changes

@ingridusta ingridusta left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Quetzacoalt91,

Sorry, the issue still happens :

Image
Enregistrement.de.l.ecran.2026-06-30.a.18.30.21.mov

2026-06-30-182458-update.txt

🙇‍♀️

@jolelievre jolelievre mentioned this pull request Jul 1, 2026
Closed
@Quetzacoalt91 Quetzacoalt91 removed waiting for author Waiting for QA Status: Action required, Waiting for test feedback labels Jul 1, 2026
@Quetzacoalt91
Quetzacoalt91 requested a review from ga-devfront July 2, 2026 10:02
Quetzacoalt91
Quetzacoalt91 commented Jul 2, 2026
View reviewed changes
Comment thread classes/UpgradeTools/CoreUpgrader/CoreServiceStub/CoreServiceStubRegistrar.php Outdated
@Quetzacoalt91
Apply suggestions from code review
3165d62 
Co-authored-by: Thomas N <Quetzacoalt91@users.noreply.github.com>
@sonarqubecloud

sonarqubecloud Bot commented Jul 2, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Quetzacoalt91 Quetzacoalt91 added the Waiting for QA Status: Action required, Waiting for test feedback label Jul 2, 2026
ingridusta
ingridusta approved these changes Jul 2, 2026
View reviewed changes

@ingridusta ingridusta left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Quetzacoalt91,

Thanks for your PR. It works as expected :

Updates 8.2.4-classic-apache to 9.2.0 & 8.0.1-apache to 9.2.0 work and new table in v9 is created after update :

Image

It's QA approved ✅ with ❤️

@ingridusta ingridusta added QA ✔️ Status: Check done, Code approved and removed Waiting for QA Status: Action required, Waiting for test feedback labels Jul 2, 2026
@Quetzacoalt91
Quetzacoalt91 merged commit bf96cc4 into PrestaShop:7.6.x Jul 2, 2026
64 checks passed
@github-project-automation github-project-automation Bot moved this from To be tested to Merged in PR Dashboard Jul 2, 2026
@Quetzacoalt91
Quetzacoalt91 deleted the stub-core-services branch July 2, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@M0rgan01 M0rgan01 M0rgan01 approved these changes
@ingridusta ingridusta ingridusta approved these changes
@ga-devfront ga-devfront Awaiting requested review from ga-devfront

Assignees

@Quetzacoalt91 Quetzacoalt91

@ingridusta ingridusta

Labels

new feature Type: New feature QA ✔️ Status: Check done, Code approved With love ❤️

Projects

PR Dashboard
Archived in project

Milestone

7.6.6

Development

Successfully merging this pull request may close these issues.

5 participants

@Quetzacoalt91 @M0rgan01 @ga-devfront @ingridusta @ps-jarvis