fix: unexpected results when embedding the same table twice#4104
Merged
Conversation
laurenceisla
commented
May 27, 2025
steve-chavez
added
the
breaking change
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Member
Since we only have major and patch releases by now, there is no need to hold this back. Also we already have some breaking changes on main anyway. |
laurenceisla
force-pushed
the
fix/alias-flt
branch
from
10bcc5e to
520be45
Compare
laurenceisla
force-pushed
the
fix/alias-flt
branch
2 times, most recently
from
71911c7 to
0143767
Compare
wolfgangwalther
force-pushed
the
fix/alias-flt
branch
from
0143767 to
c7b2be0
Compare
wolfgangwalther
approved these changes
Apr 29, 2026
Member
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
Rebased to resolve the conflict in CHANGELOG.
Member
|
@laurenceisla @wolfgangwalther This shouldn't haven been merged in this state.
I agree the change should be done but gradually. I'll push a PR shortly. Edit: done #4905 |
This was referenced May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4075
(In stand-by for a major release)