fix: set service account default creation to false#217
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the Helm chart defaults so the chart no longer creates ServiceAccounts by default, and adjusts helper templates to compute the ServiceAccount name for gateway and dataservice.
Changes:
- Set
serviceAccount.createdefault tofalsefor both gateway and dataservice invalues.yaml. - Updated
templates/_helpers.tplto enforce a non-empty ServiceAccount name whencreateisfalse(currently viafail). - Updated inline comments in
values.yamlaround ServiceAccount naming requirements.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| charts/portkey-gateway/values.yaml | Changes ServiceAccount creation defaults and updates comments for naming behavior. |
| charts/portkey-gateway/templates/_helpers.tpl | Updates helper functions that determine which ServiceAccount name is used by workloads. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b4s36t4
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.