Skip to content

test(coverage): remaining test hooks + lint fixes#138

Open
Delqhi wants to merge 24 commits into
mainfrom
feat/lint-gofmt-fixes
Open

test(coverage): remaining test hooks + lint fixes#138
Delqhi wants to merge 24 commits into
mainfrom
feat/lint-gofmt-fixes

Conversation

@Delqhi

@Delqhi Delqhi commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

This PR collects the remaining uncommitted coverage test hooks and the lint fixes needed to get CI green.

Changes

  • Adds test hooks to make error paths reachable in:
    • cmd/sin-code/internal/superpowers/superpowers.go
    • cmd/sin-code/internal/vane/vane.go and mcpserver.go
    • cmd/sin-code/tui/agent_runner_adapter.go
    • cmd/sin-code/tui/chat/input.go
    • cmd/sin-code/tui/chat/runner.go
  • Applies gofmt and goimports across the affected packages to fix the CI lint failure.
  • Includes the trace test fix that already landed in test(trace): set OTEL_EXPORTER_OTLP_HEADERS in OTLP provider test #137 (needed to resolve the branch base).

Verification

  • go test ./cmd/sin-code/... -skip 'TestRunEFM|TestDockerCompose|TestDetectContainerRuntime|TestComposeCandidates|TestResolveComposeRuntime|TestParseComposeStates|TestListEFM|TestRunSecurityScan' -count=1 -timeout 600s passes locally.
  • golangci-lint should now pass.

No breaking changes.

@vercel

vercel Bot commented Jun 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sin-code Ready Ready Preview, Comment, Open in v0 Jun 15, 2026 10:10pm

@github-actions

github-actions Bot commented Jun 14, 2026

Copy link
Copy Markdown

🏆 CEO Audit — A+ (100.0/100)

Metric Value
Grade A+
Score 100.0/100
Critical findings 0
High findings 0
Profile QUICK
Min grade gate B

📥 Download full report (Markdown)
📊 Download SARIF (for Code Scanning)

Run ~/.config/opencode/skills/ceo-audit/scripts/audit.sh . --profile=QUICK locally to reproduce.

@github-actions

github-actions Bot commented Jun 14, 2026

Copy link
Copy Markdown

🏆 CEO Audit — A+ (100.0/100)

Metric Value
Grade A+
Score 100.0/100
Critical findings 0
High findings 0
Medium findings 0
Profile QUICK
Min grade gate B

📥 Download full report (Markdown)

Run ID: 27579734507 · Commit: ${github.sha}

Run ~/.config/opencode/skills/ceo-audit/scripts/audit.sh . --profile=QUICK locally to reproduce.

if _, err := io.Copy(tmp, bytes.NewReader(data)); err != nil {
tmp.Close()
if _, err := writeJSONCopyFn(tmp, bytes.NewReader(data)); err != nil {
writeJSONCloseFn(tmp)
if _, err := tmp.Write([]byte("\n")); err != nil {
tmp.Close()
if _, err := writeJSONWriteFn(tmp, []byte("\n")); err != nil {
writeJSONCloseFn(tmp)
if _, err := io.Copy(tmp, strings.NewReader(string(data))); err != nil {
tmp.Close()
if _, err := ioCopyHook(tmp, strings.NewReader(string(data))); err != nil {
fileCloseHook(tmp)
if _, err := tmp.Write([]byte("\n")); err != nil {
tmp.Close()
if _, err := fileWriteHook(tmp, []byte("\n")); err != nil {
fileCloseHook(tmp)
Delqhi added 4 commits June 15, 2026 02:56
- Add skills/embed.go to embed skills/ directory via skillsmith

- Add sin-code skills list|install subcommand

- Add validate_skill.py --all-bundled and CI gate

- Convert all bundled skills to SKILL.md + context + frameworks + tasks + templates + LICENSE

- Wire NewSkillsCmd into main.go
skillsmith is required by the new sin-code skills list|install subcommand
Comment thread cmd/sin-code/internal/todo/id.go Fixed
Comment thread cmd/sin-code/internal/webui/server.go Fixed
- Remove duplicate adw/oracle/efm/ibd/poc commands in cli.py

- Fix except ImportError as exc scoping for fallback commands

- Add missing __all__ exports and imports

- Fix broad-regex-damaged comprehensions

- Add noqa for optional yaml import
… and add enterprise-plan + enterprise-deep-debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants