chore(main): release 0.7.2 - #1551
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1551 +/- ##
=======================================
Coverage 13.08% 13.08%
=======================================
Files 96 96
Lines 15005 15005
=======================================
Hits 1964 1964
Misses 12844 12844
Partials 197 197
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
b595e46 to
aabaf68
Compare
73900ad to
2d488e0
Compare
8a2f59e to
c36e3ec
Compare
5996b42 to
87bd016
Compare
0ef33ce to
249532e
Compare
1c65116 to
0ca8552
Compare
c6b101b to
255be17
Compare
f6a867d to
b44bc19
Compare
There was a problem hiding this comment.
🚨 Changes Requested - Found 1 significant issue (plus 1 minor observation)
This is an automated release-please PR that only modifies CHANGELOG.md. No application code changes, so categories 1–2 (security/logic bugs) are N/A. However, the release metadata itself is wrong in a way that would corrupt the project's release history.
1. Version regression / collision — this release proposes 0.7.2, which already exists and is older than the current release (breaking, must fix)
CHANGELOG.md:9 inserts a new section:
## 0.7.2 (2026-07-19)
directly above the existing top entry (CHANGELOG.md:243):
## [1.0.0](.../compare/v0.7.3...v1.0.0) (2026-05-15)
Problems:
v0.7.2already exists as a git tag (created 2026-05-07), as dov0.7.3andv1.0.0. This PR re-uses the0.7.2version number for a brand-new, differently-dated release.- The current latest release is
1.0.0. Cutting0.7.2now is a semantic-version regression — a lower version number, dated later (2026-07-19 vs 2026-05-15), placed at the top of the changelog above 1.0.0. .release-please-manifest.jsonis empty/absent in the repo, so release-please has no record that1.0.0(or0.7.3) shipped. It is recomputing the next version from a stale base and landing on an already-used number.
Recommended fix: do not merge as-is. Reconcile release-please state before regenerating this PR — populate .release-please-manifest.json with the current released version (1.0.0) so the next release computes to 1.0.1/1.1.0/2.0.0 (the changelog lists several BREAKING CHANGES, so a major bump is likely warranted). Merging this PR would collide with the existing v0.7.2 tag and leave the changelog non-monotonic.
2. Minor: many duplicate entries
The generated section contains numerous duplicated lines from rebased/cherry-picked commits with identical messages, e.g. "add demo.nhp TLS proxy to AC nginx" (cc0647c, 738a996), "add CBOR token support…" (1fb9793, cc36a68), "support multiple nhp-server clusters via pubkey-derived id" (eef8b56, d083653), "authenticate knock HeaderType" (cfa0871, 306a73f), "mark demo_nhp_cert output as sensitive" (e903f92, 3e4a817), and others. This is cosmetic and pre-exists in the 1.0.0 section too, but it's worth cleaning the commit history / squashing before the next release cut. Not blocking on its own.
Once the manifest/version state is corrected and the PR regenerated with a sane version number, this is good to go.
aff1a68 to
c2ebae1
Compare
acd3491 to
ddabe52
Compare
27cb289 to
2e50ef6
Compare
2e50ef6 to
682f715
Compare
🤖 I have created a release beep boop
0.7.2 (2026-08-10)
⚠ BREAKING CHANGES
Features
Bug Fixes
Performance Improvements
Reverts
Miscellaneous Chores
Code Refactoring
This PR was generated with Release Please. See documentation.