Skip to content

Aviary 1.0 API refresh#1113

Merged
Kenneth-T-Moore merged 14 commits into
OpenMDAO:mainfrom
jkirk5:api
Apr 29, 2026
Merged

Aviary 1.0 API refresh#1113
Kenneth-T-Moore merged 14 commits into
OpenMDAO:mainfrom
jkirk5:api

Conversation

@jkirk5

@jkirk5 jkirk5 commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Summary of PR.

Related Issues

Backwards incompatibilities

get_items(), get_values(), get_keys() functions of NamedValues are now methods whose names match Python dictionary methods (items(), values(), keys()). Deprecation warnings are in place for the removed functions.

Removed items from api.py:

  • aviary.variable_info.options: get_option_defaults (imo this is a dangerous tool and shouldn't be a user-facing function)
  • aviary.utils.named_values: get_keys, get_values, get_items (no longer exist, see above)
  • aviary.constants: MU_TAKEOFF, MU_LANDING (Unify legacy-code based constants #363)

New Dependencies

None

@jkirk5
jkirk5 marked this pull request as ready for review April 29, 2026 13:53
Comment thread aviary/api.py
from aviary.utils.aviary_values import AviaryValues
from aviary.utils.csv_data_file import read_data_file, write_data_file
from aviary.utils.data_interpolator_builder import build_data_interpolator
from aviary.variable_info.enums import (

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enums might be useful in here because users import them for their phase_info.

@jkirk5 jkirk5 Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are still there! See the next added line (import *) - I assumed users will want ALL enums, and automatically add them as we create more, although if that is not true we can revert (if some are intended to be developer only)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, they are! yeah, we probably want them all.

@jkirk5
jkirk5 added this pull request to the merge queue Apr 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 29, 2026
@Kenneth-T-Moore
Kenneth-T-Moore added this pull request to the merge queue Apr 29, 2026
Merged via the queue into OpenMDAO:main with commit 03e04ef Apr 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NamedValues get_item() does not raise error on failure

2 participants