test: add case-aware path and diff CLI regression coverage#336
Draft
cursor[bot] wants to merge 2 commits into
Draft
test: add case-aware path and diff CLI regression coverage#336cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Co-authored-by: PuritanWizard <th3w1zard1@users.noreply.github.com>
Co-authored-by: PuritanWizard <th3w1zard1@users.noreply.github.com>
Contributor
|
Message that will be displayed on users' first pull request |
Contributor
🔨 Build Validation Summary✅ Version Check: Passed Tool Builds
🎉 All builds validated successfully! This PR is ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
is_kotor_install_dir(diff CLI + TSLPatcher diff engine): installation detection with case-mismatched directory paths on POSIX (regression guard for case-aware application Case-aware application #151)ConfigReader.from_filepath: loadingchanges.iniwhen the on-disk filename casing differs from the requested pathload_kits_unified: discovering kit JSON files when the kits root directory casing differsCaseAwarePathdirectory cache:clear_cache()allows resolution to track renamed directories after cache invalidationnormalize_path_arg: PowerShell/Windows quote-mangling edge cases that previously had no direct testsTest files added/updated
Libraries/PyKotor/tests/common/test_case_aware_consumers.py(new)Libraries/PyKotor/tests/cli/test_diff_cli_utils.py(new)Why these tests materially reduce regression risk
Case-aware path resolution was rolled out across core extract, diff, and patcher entry points. Without targeted tests, a future refactor to plain
pathlib.Pathcould silently break Linux/macOS installs where users or tooling pass lower-case paths to mixed-case game directories. Thenormalize_path_argtests protect diff CLI path parsing that handles real-world PowerShell quoting bugs.Validation
All 11 tests passed on Linux (POSIX case-resolution tests skip on Windows by design).