test: add regressions for case-aware install detection and CI progress reporting#335
Draft
cursor[bot] wants to merge 2 commits into
Draft
test: add regressions for case-aware install detection and CI progress reporting#335cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
…sions Co-authored-by: PuritanWizard <th3w1zard1@users.noreply.github.com>
Co-authored-by: PuritanWizard <th3w1zard1@users.noreply.github.com>
Contributor
|
Message that will be displayed on users' first pull request |
Contributor
🔨 Build Validation Summary✅ Version Check: Passed Tool Builds
🎉 All builds validated successfully! This PR is ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds targeted regression tests for recently merged production changes where coverage was thin and business risk is meaningful.
Risky behavior now covered
is_kotor_install_dirindiff_tool/cli_utils.pyandtslpatcher/diff/engine.py): verifieschitin.keyis found even when the install path casing does not match the filesystem (POSIX). Prevents diff/TSLPatcher flows from misclassifying valid installs as plain folders.normalize_path_arg): covers quote stripping, trailing-slash cleanup, and the mangled-path pattern where a trailing backslash escapes the closing quote in PowerShell._supports_live_progress/_ExportProgressReporter): locks in the fix fromfix(json-export): log progress when automatedsoCI/GITHUB_ACTIONSforce logger-based progress instead of TTY\rupdates that bypass log capture.Test files added/updated
Libraries/PyKotor/tests/diff_tool/test_cli_utils.py(new, 11 tests)Libraries/PyKotor/tests/cli/test_resource_json_progress.py(new, 10 tests)Why these tests materially reduce regression risk
installation-to-jsonexports without failing the command.Validation
All 21 tests pass on Linux (Python 3.13).