Fix load saved lora_config.json when loading LoRA weights#329
Open
zhuxiaoxuhit wants to merge 1 commit into
Open
Fix load saved lora_config.json when loading LoRA weights#329zhuxiaoxuhit wants to merge 1 commit into
zhuxiaoxuhit wants to merge 1 commit into
Conversation
from_pretrained(lora_weights_path=...) built a default r=8 LoRAConfig and crashed for checkpoints trained with other ranks (e.g. r=32). Load the checkpoint's lora_config.json so r/alpha match; fall back to the default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VoxCPM.from_pretrained(lora_weights_path=...) builds a default r=8 LoRAConfig
and crashes (shape mismatch) for LoRA checkpoints trained with other ranks —
e.g. the r=32 produced by conf/voxcpm_v2/voxcpm_finetune_lora.yaml.
Fix
When lora_weights_path is a checkpoint dir containing lora_config.json (saved
by the training script), load LoRAConfig from it so r/alpha match; otherwise
keep the previous default.
Test
from_pretrained(lora_weights_path=) now loads cleanly
("Loaded 384 LoRA parameters, skipped 0") instead of crashing.