Skip to content

[18.0][FIX] auto_backup: open cached dump in binary mode #3659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sebastienclaude wants to merge 1 commit into
base: 18.0
Choose a base branch
from
+2 −2
Open

[18.0][FIX] auto_backup: open cached dump in binary mode #3659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion auto_backup/__manifest__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{
"name": "Database Auto-Backup",
"summary": "Backups database",
"version": "18.0.1.0.1",
"version": "18.0.1.0.2",
"author": "Yenthe Van Ginneken, "
"Agile Business Group, "
"Grupo ESOC Ingenieria de Servicios, "
Expand Down
2 changes: 1 addition & 1 deletion auto_backup/models/db_backup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def action_backup(self):
with open(os.path.join(rec.folder, filename), "wb") as destiny:
# Copy the cached backup
if backup:
with open(backup) as cached:
with open(backup, "rb") as cached:
shutil.copyfileobj(cached, destiny)
# Generate new backup
else:
Expand Down
Loading