[18.0][FIX] fetchmail_attach_from_folder: case-insensitive email matching#3657
Open
midhlaj-nk wants to merge 1 commit into
Open
Conversation
…hing PostgreSQL = operator is case-sensitive, so partners stored with mixed-case emails (e.g. Name.SURNAME@Domain.com) were not matched against lowercased incoming addresses. Switch to =ilike for exact match and ilike for domain match to make comparisons case-insensitive. Closes OCA#3402
Contributor
|
Hi @NL66278, |
OCA-git-bot
added
series:18.0
mod:fetchmail_attach_from_folder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PostgreSQL
=operator is case-sensitive. Partners stored with mixed-case emails (e.g.Name.SURNAME@Domain.com) were not matched when incoming email address had different casing (e.g.name.surname@domain.com). The existing_get_mailaddresses()already lowercases the extracted incoming address, but the search domain operator=did not account for mixed-case values stored in the database.Closes #3402
Solution
email_exact.py: change defaultoperator="="→operator="=ilike"email_domain.py: changeoperator="like"→operator="ilike"Tests
Added two new test cases:
test_email_exact_case_insensitive: partner stored with mixed-case email, incoming address lowercase → must matchtest_email_domain_case_insensitive: domain match with mixed-case stored email → must match