[18.0][FIX] auto_backup: use Markup for HTML message bodies#3655
Open
rrebollo wants to merge 1 commit into
Open
[18.0][FIX] auto_backup: use Markup for HTML message bodies#3655rrebollo wants to merge 1 commit into
rrebollo wants to merge 1 commit into
Conversation
message_post() calls markupsafe.escape() on the body parameter. Passing a plain str containing HTML tags caused them to be escaped and rendered as raw text in the chatter. Wrapping the body in Markup signals that the content is already safe HTML and should not be re-escaped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a database backup fails (or its cleanup fails), the error message is posted to the chatter via
message_post(). The body was constructed as a plain f-string containing HTML tags (<p>,<pre>), butmessage_post()callsmarkupsafe.escape()on the body. A plainstrgets HTML-escaped, causing the tags to appear as raw literal text in the chatter.Wrapping the body in
Markupsignals that the content is already safe HTML and should not be re-escaped, matching the approach used throughout Odoo 18 core and OCA modules.@BinhexTeam T22572