Skip to content

[18.0][ADD] compute_field_after_install#3648

Open
sebalix wants to merge 9 commits into
OCA:18.0from
akretion:18.0-mig-compute_field_after_install
Open

[18.0][ADD] compute_field_after_install#3648
sebalix wants to merge 9 commits into
OCA:18.0from
akretion:18.0-mig-compute_field_after_install

Conversation

@sebalix

@sebalix sebalix commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@sebalix sebalix requested a review from paradoxxxzero June 10, 2026 14:28
@OCA-git-bot OCA-git-bot added series:18.0 mod:compute_field_after_install Module compute_field_after_install labels Jun 10, 2026
@sebalix sebalix force-pushed the 18.0-mig-compute_field_after_install branch 2 times, most recently from 1f1013c to 21c7b24 Compare June 10, 2026 15:09
@sebalix sebalix force-pushed the 18.0-mig-compute_field_after_install branch from 21c7b24 to 33f9a0d Compare June 10, 2026 15:11
legalsylvain
legalsylvain requested changes Jun 10, 2026
View reviewed changes

@legalsylvain legalsylvain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a lot of questions in the initial PR regarding the design. (That has never been merged.)
Could you answer here before migrating the module ?
#2774
Thanks !

@sebalix

sebalix commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@legalsylvain I updated the module description with a warning section.
Regarding the order on id DESC it has been done on 16.0. For the use of pre_init_hook I'm lacking of context why it hasn't been done that way, probably to reduce the upgrade time to its minimum.

@sebalix sebalix marked this pull request as ready for review June 11, 2026 09:22
@legalsylvain

legalsylvain commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi . Sorry I didn't express myself clearly. I'd like we finish the discussion regarding the opportunity or not to have this module in the OCA in the first PR, to avoid arguments in many places. If you think this module is relevant, could you expose argument regarding the previous pending remarks ?

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legalsylvain legalsylvain legalsylvain requested changes
@paradoxxxzero paradoxxxzero Awaiting requested review from paradoxxxzero

Assignees

No one assigned

Labels

mod:compute_field_after_install Module compute_field_after_install series:18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sebalix @legalsylvain @OCA-git-bot @sebastienbeau @paradoxxxzero