matrix-tuwunel: run tests in debug profile - #528878
Conversation
5604893 to
6e42620
Compare
Good point. Done. |
|
The builds on 1.7.0 aren't timing out anymore. Let's wait an see what happens with the newly merged 1.7.1. If those don't time out either, I'll just close this PR. |
|
We're now seeing timeouts on x86-64 too, so this PR should probably disable check phase on all platforms. I've opened an issue with upstream to see if they have any ideas because thinking some more, 2h11m for a successful build on x86-64 does seem suspiciously long. |
|
I think I understand what is happening:
So, new plan is to just set |
6e42620 to
9828255
Compare
9828255 to
24bb6a0
Compare
|
PedroHLC
left a comment
There was a problem hiding this comment.
I won't be ablt to test it in aarch64-linux so soon
╰─λ ./results/matrix-tuwunel-x86_64-linux/bin/tuwunel --version
tuwunel 1.7.1
╰─λ du -h (readlink ./results/matrix-tuwunel-x86_64-linux)
51M /nix/store/4j2wncgw94ah3ixd33zg6fbpynwgllrr-matrix-tuwunel-1.7.1/bin
51M /nix/store/4j2wncgw94ah3ixd33zg6fbpynwgllrr-matrix-tuwunel-1.7.1`
|
Oh, right. That would be a good test. I built on aarch64 and deployed to my server. Everything works as expected since this PR doesn't change anything about the final artifacts. It was however much faster to build: this normally takes around 4h on a tiny 2 CPU VM from Hetzner, but now it took only 70m on the same hardware. |
|
@pbsds Thank you! |
|
Successfully created backport PR for |
The tuwunel build is timing out intermittently on both aarch64 and x86-64.
The specific step that causes the timeout is the
Compiling tuwunel v1.7.1 (/build/source/src/main)step duringcheckPhase. So, we're timing out building the tests and not running them.This is caused by tuwunel having 16 integration tests. Cargo compiles each of them as a separate binary which statically links 110 MB worth of tuwunel. Linking 16 big binaries like this takes a really long time in "release" profile.
Building the tests in debug profile reduces the package build from 44min to 12min on my machine. So, let's do that.
The previous version of this PR just disabled the tests, hence the first few comments below. We don't need to do that anymore.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.