matrix-tuwunel: disable check phase on aarch64#528878
Open
scvalex wants to merge 1 commit into
Open
Conversation
5604893 to
6e42620
Compare
Contributor
Author
Good point. Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tuwunel build on aarch64 is timing out in Hydra. Everything is fine on x86-64 in Hydra or when I build locally on aarch64.
This regression was likely introduced during the 1.7.0 version bump in #525790.
Pretty much the only thing that could be timing out in the build are the "smoke tests" that actually start the full server during
cargo test. So, let's try disabling check phase on aarch64.I'm not happy with disabling tests like this, but I don't know how to debug this since I can't reproduce it locally. I'd argue this is fine because the tests are still being run by Hydra on x86-64 and we'll still be running our own NixOS tests on all platforms which also exercise the server.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.