Skip to content

nixos/cosmic: remove unnecessary dependency of cosmic-session.target on xdg-desktop-autostart.target#519447

Draft
thefossguy wants to merge 1 commit into
NixOS:masterfrom
thefossguy:cosmic-module-remove-redundant-autostart-target-deps
Draft

nixos/cosmic: remove unnecessary dependency of cosmic-session.target on xdg-desktop-autostart.target#519447
thefossguy wants to merge 1 commit into
NixOS:masterfrom
thefossguy:cosmic-module-remove-redundant-autostart-target-deps

Conversation

@thefossguy

@thefossguy thefossguy commented May 12, 2026

Copy link
Copy Markdown
Member

…

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@thefossguy thefossguy requested a review from a team May 12, 2026 14:33
@thefossguy

thefossguy commented May 12, 2026

Copy link
Copy Markdown
Member Author

XDG autostart still works after this removal. Tested it by rebasing #519448 on top of this PR's HEAD and it works just fine.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: COSMIC COSMIC is a software platform for designing beautiful user experiences labels May 12, 2026
a-kenji
a-kenji approved these changes May 12, 2026
View reviewed changes

@a-kenji a-kenji left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't test yet.

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 2 This PR was reviewed and approved by two persons. label May 12, 2026
@thefossguy

thefossguy commented May 12, 2026

Copy link
Copy Markdown
Member Author

Let's hold off on merging this for a day or two until we have either the cosmic-osd fix in as a backport or as a release. Then merge the nixosTest refactor and then this one.

@thefossguy thefossguy marked this pull request as draft May 13, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@a-kenji a-kenji a-kenji approved these changes

@nyabinary nyabinary nyabinary approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: COSMIC COSMIC is a software platform for designing beautiful user experiences 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thefossguy @a-kenji @nyabinary