Fix in-process hot reload session refresh#6
Closed
NatElkins wants to merge 1 commit into
Closed
Conversation
09cc805 to
d8a9a0d
Compare
Owner
Author
|
Closing this scratch PR. The current review path is the existing constituent PR stack, especially dotnet#20031 for the in-process compile slice, plus the aggregate hot-reload-v2 preview branch. This scratch branch is based on the older perf spike branch and should not be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
dotnet build src/Compiler/FSharp.Compiler.Service.fsproj -c Debug -v minimal: passed, 0 warnings, 0 errorsdotnet test --project tests/FSharp.Compiler.Service.Tests/FSharp.Compiler.Service.Tests.fsproj -c Debug --no-build -- --filter-class "*HotReloadCheckerTests*": 36 passeddotnet test --project tests/FSharp.Compiler.Service.Tests/FSharp.Compiler.Service.Tests.fsproj -c Debug --no-build -- --filter-class "*HotReload*": 417 passedNotes
This branch is still a scratch review artifact based on
perf-optimization-spike. The code change itself is hot-reload-specific and should be folded into, or stacked directly on, the in-process compile slice before upstream review.