Skip to content

Fix in-process hot reload session refresh#6

Closed
NatElkins wants to merge 1 commit into
perf-optimization-spikefrom
oxpecker-contactapp-perf
Closed

Fix in-process hot reload session refresh#6
NatElkins wants to merge 1 commit into
perf-optimization-spikefrom
oxpecker-contactapp-perf

Conversation

@NatElkins

@NatElkins NatElkins commented Jul 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • refreshes the project output from checked results before hot reload stale-output validation when the in-process path is enabled
  • keeps the session refresh compile scoped to the resolved live hot reload session instead of leaking through a boolean mode
  • moves live emission-target tracking and scoped emission-context bracketing into hot reload state helpers
  • shares hot-reload replay-name ordinal parsing and keeps synthesized type mapping injective
  • adds generic regression coverage for stale-output refresh, unrelated CE closures in another source file, and top-level closure replay during unrelated edits

Verification

  • dotnet build src/Compiler/FSharp.Compiler.Service.fsproj -c Debug -v minimal: passed, 0 warnings, 0 errors
  • dotnet test --project tests/FSharp.Compiler.Service.Tests/FSharp.Compiler.Service.Tests.fsproj -c Debug --no-build -- --filter-class "*HotReloadCheckerTests*": 36 passed
  • dotnet test --project tests/FSharp.Compiler.Service.Tests/FSharp.Compiler.Service.Tests.fsproj -c Debug --no-build -- --filter-class "*HotReload*": 417 passed

Notes

This branch is still a scratch review artifact based on perf-optimization-spike. The code change itself is hot-reload-specific and should be folded into, or stacked directly on, the in-process compile slice before upstream review.

@NatElkins NatElkins force-pushed the oxpecker-contactapp-perf branch from 09cc805 to d8a9a0d Compare July 6, 2026 23:31
@NatElkins NatElkins changed the title Fix ContactApp in-process hot reload performance Fix in-process hot reload session refresh Jul 6, 2026
@NatElkins

Copy link
Copy Markdown
Owner Author

Closing this scratch PR. The current review path is the existing constituent PR stack, especially dotnet#20031 for the in-process compile slice, plus the aggregate hot-reload-v2 preview branch. This scratch branch is based on the older perf spike branch and should not be merged.

@NatElkins NatElkins closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant