Use uniform type names for init values throughout CUB#9267
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
SummaryStandardizes the naming of "initial-value" types across CUB to follow the project convention:
This is a mechanical rename/propagation: identifiers and local aliases were changed and the new names were propagated through dispatch templates, kernel templates, internal helpers, benchmarks, and tests. No algorithmic, behavioral, or functional changes were introduced. Scope of changes
Impact assessment
Notes for reviewers
suggestion: ## Walkthrough This PR uniformly renames initial-value type identifiers from InitT/init_t to InitValueT/init_value_t across dispatch templates, kernel signatures, device API callsites, benchmarks, and tests. suggestion: ## Changes Initial value type naming consolidation
suggestion: ## Assessment against linked issues
suggestion: ## Suggested reviewers
Comment |
This comment has been minimized.
This comment has been minimized.
🥳 CI Workflow Results🟩 Finished in 2h 24m: Pass: 100%/284 | Total: 11d 02h | Max: 2h 23m | Hits: 21%/923333See results here. |
fixes #7974
enforces existing CUB naming convention:
InitValueT: template parameters use PascalCase +Tsuffix (e.g.InputIteratorT, ReductionOpT, AccumT). These are part of the public/dispatch interface.init_value_t: local using aliases inside function bodies use snake_case +_tsuffix.