[None][fix] Uncomment Qwen3.5 and DSR1 from model registry so that they can run f…#15001
Conversation
…or acc tests Signed-off-by: Taylor Yeonbok Lee <249374542+taylor-yb-lee@users.noreply.github.com>
📝 WalkthroughWalkthroughThis PR adds three new model entries to the auto-deploy model registry: the DeepSeek-R1-0528 variant and two Qwen3.5 MoE models (35B and 397B). Each entry includes configuration references for dashboard, world-size mappings, model-specific YAML, and IR sharding enablement. ChangesModel Registry Additions
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
examples/auto_deploy/model_registry/models.yaml (1)
379-381: 💤 Low valueClarify the intentional
397B→400Bnaming in this config entry
name: Qwen/Qwen3.5-397B-A17Bmaps toconfig_id: qwen3_5_moe_400bandyaml_extraincludesqwen3.5_moe_400b.yaml.- A search only finds
qwen3.5_moe_400b.yaml(noqwen3.5_moe_397b.yaml/other397bvariants), so switchingconfig_idto..._397bwould break the existing mapping; document the rounding convention instead.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@examples/auto_deploy/model_registry/models.yaml` around lines 379 - 381, The entry's display name "Qwen/Qwen3.5-397B-A17B" doesn't match the config_id "qwen3_5_moe_400b" and yaml_extra file "qwen3.5_moe_400b.yaml"; update the models.yaml entry to add a clarifying comment or field next to name/config_id that states the project uses a rounding/labeling convention (e.g., display shows exact parameter count 397B while internal config and filenames use rounded 400B) so readers know this mismatch is intentional; reference the "name", "config_id", and "yaml_extra" values and the file "qwen3.5_moe_400b.yaml" when adding the single-line clarification.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@examples/auto_deploy/model_registry/models.yaml`:
- Around line 379-381: The entry's display name "Qwen/Qwen3.5-397B-A17B" doesn't
match the config_id "qwen3_5_moe_400b" and yaml_extra file
"qwen3.5_moe_400b.yaml"; update the models.yaml entry to add a clarifying
comment or field next to name/config_id that states the project uses a
rounding/labeling convention (e.g., display shows exact parameter count 397B
while internal config and filenames use rounded 400B) so readers know this
mismatch is intentional; reference the "name", "config_id", and "yaml_extra"
values and the file "qwen3.5_moe_400b.yaml" when adding the single-line
clarification.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f8e519b2-3f94-443b-86ae-c186d11f1803
📒 Files selected for processing (1)
examples/auto_deploy/model_registry/models.yaml
|
/bot run --disable-fail-fast --stage-list "DGX_B200-8_GPUs-AutoDeploy-Post-Merge-1" |
|
PR_Github #52316 [ run ] triggered by Bot. Commit: |
|
PR_Github #52316 [ run ] completed with state |
|
/bot skip --comment "autodeploy model registry change, affected tests passed in pipeline #52316" |
|
PR_Github #52342 [ skip ] triggered by Bot. Commit: |
|
PR_Github #52342 [ skip ] completed with state |
…ey can run f… (NVIDIA#15001) Signed-off-by: Taylor Yeonbok Lee <249374542+taylor-yb-lee@users.noreply.github.com> Signed-off-by: NVFB <186336021+NVFB@users.noreply.github.com>
Summary by CodeRabbit
Description
In PR #14686, Qwen3.5 and DSR1 are commented out from model registry.
At the same time, those acc tests were unwaived and post merge test is crashing because of the missing parmeter.
This PR uncommenting those models from the registry
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.