Skip to content

[https://nvbugs/6224637][test] unwaive associated tests#14993

Open
yuxianq wants to merge 1 commit into
NVIDIA:mainfrom
yuxianq:test/unwaive-nvbug-6224637
Open

[https://nvbugs/6224637][test] unwaive associated tests#14993
yuxianq wants to merge 1 commit into
NVIDIA:mainfrom
yuxianq:test/unwaive-nvbug-6224637

Conversation

@yuxianq
Copy link
Copy Markdown
Collaborator

@yuxianq yuxianq commented Jun 5, 2026

Summary

Validation

  • rg -n '6224637' tests/integration/test_lists/waives.txt || true
  • git diff --check origin/main...HEAD
  • pre-commit on commit

Test Coverage

  • Waiver-only change; no local GPU tests run.

Summary by CodeRabbit

  • Tests
    • Updated test skip list configuration for accuracy tests.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 5, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1bdc5149-15b2-437d-8a49-5953e28a13b2

📥 Commits

Reviewing files that changed from the base of the PR and between 4574851 and 8a18308.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

The PR updates test waiver skip entries in tests/integration/test_lists/waives.txt for the TestDeepSeekV3Lite test class. The test_bfloat16_4gpus section removes older pipeline-parallel and torch_compile variant waivers and adds new tensor-parallel and scheduler-specific SKIPs. The test_nvfp4_4gpus section removes multiple CUTLASS backend waivers with mtp_nextn=0 across different configurations, retaining a single mtp_nextn=2 fp8kv variant.

Changes

DeepSeekV3Lite waiver list updates

Layer / File(s) Summary
Test waiver configuration updates
tests/integration/test_lists/waives.txt
Updated skip entries for TestDeepSeekV3Lite::test_bfloat16_4gpus by removing older pp4/torch_compile-variant waivers (and associated fp8 block scale entries) and adding new tp4-based SKIPs with updated bfloat16_python_scheduler and cute_dsl 4-gpu waivers. Adjusted test_nvfp4_4gpus CUTLASS waivers by removing multiple pp4 mtp_nextn=0 entries across different torch_compile/fp8kv combinations and keeping/adding the mtp_nextn=2 fp8kv=True torch_compile=False SKIP entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14946: Modifies the same waiver file with updates to TestDeepSeekV3Lite skip entries and NVBug references.
  • NVIDIA/TensorRT-LLM#14523: Directly updates the same TestDeepSeekV3Lite fp8 block scale and test_nvfp4_4gpus CUTLASS mtp_nextn/fp8kv waiver entries.
  • NVIDIA/TensorRT-LLM#10835: Modifies the same waives.txt file by changing skipped test cases for the same test class.

Suggested reviewers

  • StanleySun639
  • xinhe-nv
  • LarryXFly
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly indicates the PR removes test waivers for a specific bug tracking issue, which aligns with the changeset of updating waives.txt.
Description check ✅ Passed The description includes a clear summary of changes, validation steps performed, and test coverage explanation, though it deviates from the required template structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@yuxianq yuxianq requested a review from xinhe-nv June 5, 2026 06:19
@yuxianq
Copy link
Copy Markdown
Collaborator Author

yuxianq commented Jun 5, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #52276 [ run ] triggered by Bot. Commit: 8a18308 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #52276 [ run ] completed with state SUCCESS. Commit: 8a18308
/LLM/main/L0_MergeRequest_PR pipeline #41587 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
@yuxianq yuxianq force-pushed the test/unwaive-nvbug-6224637 branch from 8a18308 to ea2788c Compare June 6, 2026 05:07
Copy link
Copy Markdown
Collaborator Author

yuxianq commented Jun 6, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #52478 [ run ] triggered by Bot. Commit: ea2788c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #52478 [ run ] completed with state SUCCESS. Commit: ea2788c
/LLM/main/L0_MergeRequest_PR pipeline #41770 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants