Skip to content

[https://nvbugs/6250866][fix] Fix deep ep partial warp sync for gptoss shapes #14977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dongfengy merged 1 commit into from
Jun 6, 2026
+37 −1
Merged

[https://nvbugs/6250866][fix] Fix deep ep partial warp sync for gptoss shapes #14977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion 3rdparty/fetch_content.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
"display_name": "deep_ep",
"git_repository": "${github_base_url}/deepseek-ai/DeepEP",
"git_tag": "5be51b228a7c82dbdb213ea58e77bffd12b38af8",
"use_url": true
"use_url": true,
"patch_file": "patches/deep_ep_intranode_combine_fix.patch"
},
{
"name": "deepgemm",
Expand Down
35 changes: 35 additions & 0 deletions 3rdparty/patches/deep_ep_intranode_combine_fix.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
--- a/csrc/kernels/intranode.cu
+++ b/csrc/kernels/intranode.cu
@@ -844,9 +844,15 @@

#ifndef DISABLE_SM90_FEATURES
// Wait TMA arrival
+ // hidden_int4 is not always divisible by a warp. The final tile can have
+ // only a subset of lanes active, so synchronize only participating lanes.
+ auto const tile_start = i - lane_id;
+ auto const active_lanes = min(32, hidden_int4 - tile_start);
+ auto const sync_mask = active_lanes == 32 ? 0xffffffffu : ((1u << active_lanes) - 1u);
+
if (lane_id == 0)
tma_store_wait<kNumStages - 1>();
- __syncwarp();
+ __syncwarp(sync_mask);

// Write into TMA buffer
auto tma_stage_idx = (i / 32) % kNumStages;
@@ -854,13 +860,13 @@

// Issue TMA
tma_store_fence();
- __syncwarp();
+ __syncwarp(sync_mask);
if (lane_id == 0) {
auto tma_bytes = min(32, hidden_int4 - i) * static_cast<int>(sizeof(int4));
tma_store_1d(reinterpret_cast<int4*>(tma_buffer) + tma_stage_idx * 32,
recv_int4 + token_idx * hidden_int4 + i, tma_bytes, false);
}
- __syncwarp();
+ __syncwarp(sync_mask);
#else
recv_int4[token_idx * hidden_int4 + i] = out_int4;
#endif
Loading