[None][feat] Add LTX-2 visual generation example#14976
Conversation
Signed-off-by: Yibin Li <109242046+yibinl-nvidia@users.noreply.github.com>
📝 WalkthroughWalkthroughThis PR adds a complete LTX-2 text-to-video example to the VisualGen module. It includes a new YAML configuration file defining LTX-2 defaults, a Python example script that parses CLI arguments, loads configuration, and generates video output, and a README update documenting the new example. ChangesLTX-2 Visual Generation Example
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@examples/visual_gen/models/ltx2.py`:
- Line 28: The function signature for main lacks a return type annotation;
update the definition of main (def main) to include an explicit return type of
-> None (i.e., change to def main() -> None:) so it conforms to the repo typing
rule that all functions must be annotated and use None for no return value.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6e769eea-3562-44c6-a42e-f39894e75fa3
📒 Files selected for processing (3)
examples/visual_gen/README.mdexamples/visual_gen/configs/ltx2.yamlexamples/visual_gen/models/ltx2.py
Signed-off-by: Yibin Li <109242046+yibinl-nvidia@users.noreply.github.com>
d20d450 to
c80be94
Compare
|
/bot run |
|
PR_Github #52202 [ run ] triggered by Bot. Commit: |
|
/bot kill |
|
PR_Github #52236 [ kill ] triggered by Bot. Commit: |
|
PR_Github #52202 [ run ] completed with state |
|
PR_Github #52236 [ kill ] completed with state |
|
/bot run |
|
PR_Github #52240 [ run ] triggered by Bot. Commit: |
|
/bot kill |
|
PR_Github #52304 [ kill ] triggered by Bot. Commit: |
|
PR_Github #52304 [ kill ] completed with state |
|
/bot run |
|
PR_Github #52309 [ run ] triggered by Bot. Commit: |
|
PR_Github #52309 [ run ] completed with state |
Signed-off-by: Yibin Li <109242046+yibinl-nvidia@users.noreply.github.com>
Signed-off-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
Description
Adds a minimal LTX-2 text-to-video VisualGen example, including:
examples/visual_gen/models/ltx2.pyfor running an LTX-2 generation request.examples/visual_gen/configs/ltx2.yamlwith the default VisualGen settings for the example.Test Coverage
pre-commit run --files examples/visual_gen/README.md examples/visual_gen/configs/ltx2.yaml examples/visual_gen/models/ltx2.py/bot runafter the lightweight PR checks are clean for the current head.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.