fixed warmup method in Xspress3HDF5Plugin

[Dan Henriksen (dihenriksen)]

Fixes #257

[Jakub Wlodek (jwlodek)]

Since the method is identical to the upstream one other than the two signals, I wonder if we should change warmup upstream to take a dictionary of signals to values to set? Maybe not worth the effort, but it would certainly allow for less code duplication...

Or maybe have a property that stores the dict of signals to set on warmup.

[Dan Henriksen (dihenriksen)]

Since the method is identical to the upstream one other than the two signals, I wonder if we should change warmup upstream to take a dictionary of signals to values to set? Maybe not worth the effort, but it would certainly allow for less code duplication...

Or maybe have a property that stores the dict of signals to set on warmup.

I thought about that too. It might be the best and cleanest solution - it is easy for me to imagine other detectors having to tweak the signals for the HDF5Plugin as well. But since that change would be in ophyd I am worried about unintended downstream consequences and backwards compatibility. And I'm still only vaguely familiar with ophyd so I wasn't confident in making that change there.

[Dan Henriksen (dihenriksen)]

Jakub Wlodek (@jwlodek) I at least made in issue in ophyd: bluesky/ophyd#1280