Added function that searches for proposals by PI name#249
Added function that searches for proposals by PI name#249Juan Marulanda (jmaruland) wants to merge 8 commits into
Conversation
|
After receiving some feedback from BL staff, I added an additional input parameter that allows optional queries. This is intended for other filed in the start document that BL staff would find useful to search for proposals. I narrowed down the search to string and numerical types; other data types are not included. |
Max Rakitin (mrakitin)
left a comment
There was a problem hiding this comment.
It's a useful feature.
|
Could we add some unit tests that cover this functionality? Also type hints for the function arguments would be nice |
|
Juan Marulanda (@jmaruland) let me know that some queries time out (against SQL-backed catalogs). Better indexes are needed to support this. We aim to add those in the next maintenance (June 16) and it does not need to be a blocker for merging this PR. I agree with Jakub Wlodek (@jwlodek) that it's worth adding unit tests and type hints. |
|
Thanks for all the comments to improve this PR. I will add all these features next. Dan Allan (@danielballan) my tests using the sql-backed catalogs have not passed this line that involves the Like() method and unfortunately, this is the only line that I cannot test with the mongo-backed catalogs. |
This PR adds a function that will allow BL staff to search in tiled for proposals in by PI name and cycle (optional). The goal is to allow BL staff to import this method in their bsui environment and have this function at hand during their experiments.
This function was tested with the OPLS and SMI catalogs