fix(migrate): cover legacy app migration edge cases - #4
Merged
Conversation
📊 Code Coverage Report
Coverage by File
|
dxnter
marked this pull request as ready for review
April 27, 2026 15:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tightens the
chassis:migrateflow for a few real-world app shapes found during migration testing.What changed
UpgradeApiTokenModelStepto upgrade legacy token models toAccessTokenContractAccessTokenandApiTokenmodel locationsexpires_atvalid_from/valid_tolast_ip_usedwhen recording token usage if that column existsUpgradeRebuildDatabaseCommandStepto handle older linearhandle()implementations in addition to the canonical$stepsarray shapeBaseRebuildDatabaseCommandViewServiceProvidercleanup after removing the@datetimedirective so emptyboot()methods remain valid and cleanly formattedSysdevtoSysDevfor generated subclassesWhy
These fixes came out of validating
chassis:migrateagainst multiple downstream apps with slightly different starter histories. Without them, migrations could produce broken imports, malformed provider output, or miss legacy command and token model shapes.Impact
Apps migrating to
chassisshould now get safer output for legacy rebuild commands, legacy token models, and generated subclass stubs without requiring manual cleanup after the migration runs.Root cause
The migration flow assumed a narrower set of app shapes than what exists in the field:
$stepsarray structure