Skip to content

Changing s3 authentication to use anon bucket#337

Merged
varsiha-sothilingam merged 4 commits into
mainfrom
anon_bucket
Jun 11, 2026
Merged

Changing s3 authentication to use anon bucket#337
varsiha-sothilingam merged 4 commits into
mainfrom
anon_bucket

Conversation

@varsiha-sothilingam

Copy link
Copy Markdown
Contributor

Description

Closes #issue_number

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • If you are working on the documentation, please ensure the current build passes
  • All tests pass

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.13%. Comparing base (77f0571) to head (ea2525d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #337   +/-   ##
=======================================
  Coverage   93.13%   93.13%           
=======================================
  Files           7        7           
  Lines         685      685           
=======================================
  Hits          638      638           
  Misses         47       47           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@valeriupredoi valeriupredoi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @varsiha-sothilingam - could you please change the ones in tests/test_real_s3_with_axes.py too, and one in tests/test_real_s3.py - I reckon best we kept one, but the one in tests/test_real_s3.py::test_s3_small_file can prob be replaced 🍺

@varsiha-sothilingam

Copy link
Copy Markdown
Contributor Author

Hi @valeriupredoi Thanks for following up the PR. I have updated the relevant files now. Once tests have passed I will merge it into main if you are also happy with it. Cheers

@valeriupredoi valeriupredoi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM many thanks @varsiha-sothilingam

@varsiha-sothilingam varsiha-sothilingam merged commit 31425fa into main Jun 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing testing duh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants