Changing s3 authentication to use anon bucket#337
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
=======================================
Coverage 93.13% 93.13%
=======================================
Files 7 7
Lines 685 685
=======================================
Hits 638 638
Misses 47 47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
valeriupredoi
left a comment
There was a problem hiding this comment.
thanks @varsiha-sothilingam - could you please change the ones in tests/test_real_s3_with_axes.py too, and one in tests/test_real_s3.py - I reckon best we kept one, but the one in tests/test_real_s3.py::test_s3_small_file can prob be replaced 🍺
|
Hi @valeriupredoi Thanks for following up the PR. I have updated the relevant files now. Once tests have passed I will merge it into main if you are also happy with it. Cheers |
valeriupredoi
left a comment
There was a problem hiding this comment.
LGTM many thanks @varsiha-sothilingam
Description
Closes #issue_number
Before you get started
Checklist