Bump pinned MEOS to 008ef1c2a5 (ecosystem-pin-2026-06-18b)#204
Open
estebanzimanyi wants to merge 5 commits into
Open
Bump pinned MEOS to 008ef1c2a5 (ecosystem-pin-2026-06-18b)#204estebanzimanyi wants to merge 5 commits into
estebanzimanyi wants to merge 5 commits into
Conversation
estebanzimanyi
force-pushed
the
feat/pin-2026-06-18b
branch
2 times, most recently
from
795765f to
3994c78
Compare
estebanzimanyi
added a commit
to MobilityDB/MobilityDB
that referenced
this pull request
Jun 20, 2026
The bundled `cmake/FindGEOS.cmake` resolves `libgeos_c` by absolute path
and links it directly. Under **vcpkg manifest mode on macOS**, ninja
reports that absolute `.dylib` as a missing, unbuildable input and the
link of `libmeos.dylib` fails:
```
ninja: error: '.../vcpkg_installed/x64-osx-release/lib/libgeos_c.dylib',
needed by 'libmeos.dylib', missing and no known rule to make it
```
The same pin links GEOS cleanly on Linux and all Wasm triplets — only
macOS/vcpkg fails (MobilityDB/MobilityDuck#204).
**Fix:** GEOS (upstream, and via vcpkg) ships a CMake CONFIG package
exporting the `GEOS::geos_c` imported target with correct per-platform
library handling. Prefer it when present (deriving the `GEOS_VERSION_*`
components from the config version), and fall back to the bundled
`FindGEOS` module for system installs without a CMake config.
**Verified on Linux** (which also ships the GEOS CMake config, so it
exercises the new path): `Found GEOS 3.12.1 via CONFIG (GEOS::geos_c)`,
`POSTGIS_GEOS_VERSION: 31201`, full all-families build of both `libmeos`
and the extension green. macOS/vcpkg is confirmed by the MobilityDuck
#204 matrix.
Register the quadbin / tquadbin cell-index types and their cast, accessor, and operator surface, with the rtree index module and build wiring.
… 1.4.4 DuckDB runs scalar, cast and table-function bodies on worker threads whose MEOS thread-local state is uninitialised; initialize MEOS once per worker thread at the registration chokepoints and table-function Init bodies, and consume the DuckDB 1.4.4 unique_ptr_cast Copy signature.
The restrict argument was dropped from the spatiotemporal relationships in the 1.4 orthogonalization; drop the non-canonical 3-arg overloads and use the 2-arg form in the tests.
Refresh expecteds that drifted with the pin: share-inclusive span adjacency, ln/log10/exp densification, and right-open step segment-duration bounds, all matching MobilityDB canonical output.
Pin the MEOS vcpkg port to ecosystem-pin-2026-06-22a (043d5e72), carrying the GEOS CMake CONFIG-target fix for the macOS build. Consume the pgtypes public leaf headers for date/timestamp arithmetic and drop the obsolete source patches the clean MEOS-only surface makes unnecessary.
estebanzimanyi
force-pushed
the
feat/pin-2026-06-18b
branch
from
75f654b to
af1db19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advance the MEOS vcpkg pin from d94af2d2c9 to 008ef1c2a5 (ecosystem-pin-2026-06-18b, 2026-06-18). The two portfile patches that worked around upstream gaps — the QUADBIN PROJECT_OBJECTS→MEOS_OBJECTS redirect and the basetype_byvalue dead-code removal — are applied directly in the new pin and are removed from portfile.cmake. Four remaining patches (T_JSONB temporal parse, pq_sendint elog→meos_error, pg_timestamp.h cross-guard, postgres_ext_defs.in.h add_*) are still needed and unchanged. The MOBILITYDUCK_MEOS_PIN constant in mobilityduck_extension.cpp is updated to match.