Align value domain handling to the VTL 2.2 standard#864
Open
albertohernandez1995 wants to merge 8 commits into
Open
Align value domain handling to the VTL 2.2 standard#864albertohernandez1995 wants to merge 8 commits into
albertohernandez1995 wants to merge 8 commits into
Conversation
…de_vd type) and errorlevel defaults to Integer (or errorlevel_vd type) per VTL 2.2, replacing per-literal type inference in the pandas validation operators.
Add an optional value_domain field to Component, serialized as the schema's `subset` key only when set, and populate it in both loader branches. Viral attribute propagation now resolves value-domain rules via the real field instead of a getattr fallback.
…mains. Added new error message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns value-domain handling with the VTL 2.2 standard:
errorcodedefaults toString(or theerrorcode_vdvalue domain's type) anderrorleveltoInteger(orerrorlevel_vd), via a shared resolver used by both the pandas interpreter and the duckdb transpiler.check_datapoint/check_hierarchydefined on avaluedomainsignature now validate that the mapped components are defined on the signature's value domains (new error1-1-10-11), skipping components without a declared value domain.Componentgains avalue_domainfield loaded from the data-structuresubsetkey; viral-attribute propagation now resolves value-domain rules via it.Closes #632.
Checklist
ruff format,ruff check,mypy)pytest) — 5125 passed, 11 skipped