#303 callback data refactoring#308
Open
westei wants to merge 1 commit into
Open
Conversation
…on and participant are retrieved and validated based on the callback parameters. The ObservationComponents just need to process additional parameters. This also prepares the system to be refactored to use a callback token instead of parameters exposing internal ids
Contributor
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 67feb74. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still Work in Progress. The code compiles, but Tests are not yet adapted
The main Idea is:
ObservationExecutionServicegets all the parameters of the callback. The controller does no processing of the parameterObservationExecutionServicedetermines Study, Participant and Observations based on the callback and stores them in theCallbackDataclass.Internally RoutingInfo is still used. It is provided by a getter of the
CallbackDataThis provides a clear separation of concerns and allows to transition the system in future to a token based approach, where a callback token is provided by the callback and this token is later used to lookup callback specific data.