GYRE 9.1#1016
Merged
Merged
Conversation
…ding math-slots subdir to PKG_CONFIG_PATH
The omp simd directive assumes that all loop iterations are independent. This is not the case for swapping elements of a single row/column. Hence, this causes UB.
rhdtownsend
requested review from
Debraheem,
VincentVanlaer and
warrickball
as code owners
Contributor
Author
|
When building on MacOS aarch64 (as opposed to MacOS Intel), GYRE now needs the 26.5.1 SDK. This will have to be uploaded to Zenodo, and the github actions modified accordingly. |
Member
|
I believe @matteocantiello is the one who will have to upload the new sdk to zenodo. As far as updating the github actions, once the sdks are uploaded, we can update them on this branch to make sure it's working before a merge. |
Contributor
Author
|
Yeah, I left those in in case we need to run some older-SDK builds, but I can certainly remove them.
… On Jun 11, 2026, at 2:25 PM, Vincent Vanlaer ***@***.***> wrote:
@VincentVanlaer commented on this pull request.
In .github/workflows/build.yml:
> @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
- sdk: ["26.3.2"] # pick 2 or 3 most recent.
+ sdk: ["26.6.1"] # pick 2 or 3 most recent.
Since this removes 26.3.2 from the test matrix, the links could also be removed from install-sdk-linux and install-sdk-macos.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you authored the thread.Message ID: ***@***.***>
--
Rich Townsend • Professor of Astronomy
Astronomy Department • University of Wisconsin-Madison
Phone: 608-262-1752 • E-mail: ***@***.***
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to GYRE 9.1, which was (quietly) released today.