Skip to content

SF bugfixes in path_finder#198

Open
Luke-Poeppel wants to merge 4 commits into
devfrom
path_finder_sf
Open

SF bugfixes in path_finder#198
Luke-Poeppel wants to merge 4 commits into
devfrom
path_finder_sf

Conversation

@Luke-Poeppel

Copy link
Copy Markdown
Owner

Fixes #197.

  • There's still an onset range bug with split_extractions. See the series of Proceleusmatic in SF1.
  • I added a condition to ensure any remaining sinks that aren't in the path (but still can be) are chosen. But SF1 ignores a viable trochee at the end.
  • It seems like Tribrachs are getting consistently ignored... Probably good idea to add Ditribrach for consitency. Might solve some of this.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #198 (4a120e4) into dev (1d8ee49) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #198   +/-   ##
=======================================
  Coverage   78.46%   78.46%           
=======================================
  Files          17       17           
  Lines        2401     2401           
=======================================
  Hits         1884     1884           
  Misses        517      517           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants