Skip to content

feat: unikey engine#179

Draft
Zebra2711 wants to merge 42 commits into
LotusInputMethod:devfrom
Zebra2711:next
Draft

feat: unikey engine#179
Zebra2711 wants to merge 42 commits into
LotusInputMethod:devfrom
Zebra2711:next

Conversation

@Zebra2711

@Zebra2711 Zebra2711 commented Mar 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

dùng unikey engine

  • marco
  • auto non-vn restore
  • firefox uinput bug (fixes in Zebra2711@0717ed1)
  • Surrounding Text broken
  • clean stuff
  • ...

Đã fix libreoffice uinput mode
Lưu ý khi dùng: vì vẫn chưa hoàn thiện nên

  • firefox base nên dùng preedit
  • các app sử dụng electron/cef/chromium nếu lỗi uinput thì add thêm app vào ack_apps rồi build lại.
  • LOTUS_ENABLE_AVX512 mặc định auto build nhưng nếu cpu k hỗ trợ thì set flag cmake -DLOTUS_ENABLE_AVX512=OFF khi build

@github-project-automation github-project-automation Bot moved this to Backlog in Kanban Mar 28, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 28, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the LotusState::performReplacement function to utilize deleteSurroundingText for applications that support it, aiming for a smoother typing experience. The review feedback identifies a critical issue where calling .back() on an empty string could cause a crash and points out a block of dead code resulting from contradictory logic regarding the autofillOffset variable.

Comment thread src/lotus-state.cpp
Comment thread src/lotus-state.cpp Outdated
@Miho1254

Miho1254 commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

@Miho1254 mode chỉ dành cho libreofice :)

có mỗi thằng libre support API này thôi à

@Zebra2711

Zebra2711 commented Mar 28, 2026

Copy link
Copy Markdown
Contributor Author

@Miho1254 mode chỉ dành cho libreofice :)

có mỗi thằng libre support API này thôi à

mấy thằng khác dùng đc nhưng bị lỗi :v

@Zebra2711 Zebra2711 marked this pull request as draft March 28, 2026 14:24
@nhktmdzhg

nhktmdzhg commented Mar 28, 2026

Copy link
Copy Markdown
Collaborator

@Miho1254 mode chỉ dành cho libreofice :)

có mỗi thằng libre support API này thôi à

thằng nào gtk với qt là được, thậm chí firefox cũng có, lỏ quá thôi

@Zebra2711 Zebra2711 force-pushed the next branch 5 times, most recently from 41ef9d1 to 08341ee Compare March 28, 2026 15:57
@Zebra2711 Zebra2711 changed the title feat: use deleteSurroundingText for app support hotfix: include experimental patches (temporary workaround, pending upstream...) Mar 28, 2026
@Zebra2711 Zebra2711 force-pushed the next branch 5 times, most recently from 218dcce to 5c53cdb Compare March 30, 2026 04:18
@Zebra2711 Zebra2711 force-pushed the next branch 2 times, most recently from d5b4113 to 9faab2d Compare May 14, 2026 04:36
@Zebra2711 Zebra2711 changed the title hotfix: include experimental patches (temporary workaround, pending upstream...) feat: unikey engine May 14, 2026
Zebra2711 added 5 commits May 14, 2026 13:31
@Zebra2711
rm stuff
af0311f 
Signed-off-by: Zebra2711 <zebra2711t@gmail.com>
@Zebra2711
rm stuff
c90b4aa 
Signed-off-by: Zebra2711 <zebra2711t@gmail.com>
@Zebra2711
rm stuff ui
6f3d3b2 
Signed-off-by: Zebra2711 <zebra2711t@gmail.com>
@Zebra2711
fix SIGSEGV
2000c3e 
Signed-off-by: Zebra2711 <zebra2711t@gmail.com>
@Zebra2711
rm stuff
54278e1 
Signed-off-by: Zebra2711 <zebra2711t@gmail.com>
@nhktmdzhg

nhktmdzhg commented May 14, 2026

Copy link
Copy Markdown
Collaborator

vainoi, anh này oách xà lách

@Zebra2711
ee
7d89d99 
Signed-off-by: Zebra2711 <zebra2711t@gmail.com>
@Miho1254

Miho1254 commented May 14, 2026

Copy link
Copy Markdown
Contributor

t muốn pull bản này về

@Zebra2711

Zebra2711 commented May 16, 2026

Copy link
Copy Markdown
Contributor Author

@Miho1254 dùng cũng tạm rồi,test đê :)

@Miho1254

Miho1254 commented May 17, 2026

Copy link
Copy Markdown
Contributor

@Miho1254 dùng cũng tạm rồi,test đê :)

lời chào thân ái từ fcitx5-lotus-unikey, work out of the box!!!

@nhktmdzhg nhktmdzhg force-pushed the dev branch 2 times, most recently from b60cc15 to 3e3ec05 Compare July 14, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
@shadichy shadichy shadichy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Kanban
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Zebra2711 @Miho1254 @nhktmdzhg @shadichy