Skip to content

Feature Blizzard API update#30

Open
LogansUA wants to merge 8 commits into
masterfrom
feature/new-blizzard-api-update
Open

Feature Blizzard API update#30
LogansUA wants to merge 8 commits into
masterfrom
feature/new-blizzard-api-update

Conversation

@LogansUA

Copy link
Copy Markdown
Owner

Global library update in order to use Blizzard API after it was updated

@tpageforfunzies

Copy link
Copy Markdown

hey how is progress going on this? I was about to start something similar and would rather help you update this than start over

@LogansUA

LogansUA commented Feb 11, 2019

Copy link
Copy Markdown
Owner Author

hey how is progress going on this? I was about to start something similar and would rather help you update this than start over

Hey, I'm a bit busy now at work.
If you want to help you can test the WoW part and update SC2/D3 part if you have free time :)

Here's the Postman Collections for Blizzard API you can use them for faster development.

@albertogcatalan

Copy link
Copy Markdown

Hey @LogansUA, how is progress going on this?

@LogansUA

LogansUA commented Aug 7, 2019

Copy link
Copy Markdown
Owner Author

Hey @LogansUA, how is progress going on this?

Hey, I really forgot about this task.
As I said if you want to help, please help :)

Probably on this weekend I'll take a look and maybe finally finish this one.

@benargo

benargo commented Aug 14, 2019

Copy link
Copy Markdown

Hey, I'm using this for WoW, is there anything I can do to help on this front? 🙃

@LogansUA

Copy link
Copy Markdown
Owner Author

Hey, I'm using this for WoW, is there anything I can do to help on this front? 🙃

Well, basically this code should be tested first
Also I'm not sure that I added all changes that are currently have Blizzard API so this thing should be checked too.

@benargo

benargo commented Aug 15, 2019

Copy link
Copy Markdown

Would it be helpful if I created a test suite and added it to this branch/PR?

@LogansUA

Copy link
Copy Markdown
Owner Author

Would it be helpful if I created a test suite and added it to this branch/PR?

I believe it would be great :)

@benargo

benargo commented Aug 16, 2019

Copy link
Copy Markdown

Cool, I've forked the branch and started working on this in my spare time. I'll publish what I've got around the end of next week (as I'll be pretty busy once WoW Classic launches 😉)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants