Skip to content

fix(macos): #3433 cursor reappears correctly after typing - #5107

Draft
martona wants to merge 5 commits into
LizardByte:masterfrom
martona:macos-video-pr
Draft

fix(macos): #3433 cursor reappears correctly after typing#5107
martona wants to merge 5 commits into
LizardByte:masterfrom
martona:macos-video-pr

fix aspect ratio, because VideoToolbox letterbox does not do what it …

895a19c
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 15, 2026 in 55s

Quality Gate failed

Failed conditions
11 New issues
11 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 177 in src/platform/macos/nv12_zero_device.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a field "data" in the outer scope.

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ4tOfA1sUE0sUAeeL1e&open=AZ4tOfA1sUE0sUAeeL1e&pullRequest=5107

Check warning on line 245 in src/platform/macos/nv12_zero_device.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array.

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ4tOfA1sUE0sUAeeL1g&open=AZ4tOfA1sUE0sUAeeL1g&pullRequest=5107

Check warning on line 251 in src/platform/macos/nv12_zero_device.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array.

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ4tOfA1sUE0sUAeeL1h&open=AZ4tOfA1sUE0sUAeeL1h&pullRequest=5107

Check warning on line 93 in src/platform/macos/nv12_zero_device.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array.

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ4s-UOi5mgfDCRRWvpn&open=AZ4s-UOi5mgfDCRRWvpn&pullRequest=5107

Check warning on line 87 in src/platform/macos/nv12_zero_device.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array.

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ4s-UOi5mgfDCRRWvpm&open=AZ4s-UOi5mgfDCRRWvpm&pullRequest=5107

Check warning on line 309 in src/platform/macos/nv12_zero_device.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a field "resolution_fn" in the outer scope.

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ4s-UOi5mgfDCRRWvpp&open=AZ4s-UOi5mgfDCRRWvpp&pullRequest=5107

Check warning on line 177 in src/platform/macos/nv12_zero_device.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array.

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ4tOfA1sUE0sUAeeL1d&open=AZ4tOfA1sUE0sUAeeL1d&pullRequest=5107

Check warning on line 309 in src/platform/macos/nv12_zero_device.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a field "resize_capture" in the outer scope.

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ4s-UOi5mgfDCRRWvpq&open=AZ4s-UOi5mgfDCRRWvpq&pullRequest=5107

Check warning on line 309 in src/platform/macos/nv12_zero_device.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a field "display" in the outer scope.

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ4s-UOi5mgfDCRRWvpo&open=AZ4s-UOi5mgfDCRRWvpo&pullRequest=5107

Check warning on line 178 in src/platform/macos/nv12_zero_device.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array.

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ4tOfA1sUE0sUAeeL1f&open=AZ4tOfA1sUE0sUAeeL1f&pullRequest=5107

Check failure on line 309 in src/platform/macos/nv12_zero_device.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type.

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ4s-UOi5mgfDCRRWvpr&open=AZ4s-UOi5mgfDCRRWvpr&pullRequest=5107